Output a warning when manageTLS is enabled but the port is 9080

[leochr]

As part of the validation of CR, output a warning (not error) when manageTLS is enabled (by default it is) but .spec.service.port is set to 9080. The message should be output to Reconciled status

• Completed for RCO
• Completed for OLO
• Completed for WLO
• Tests

[idlewis]

@leochr Is the intention here to add a message field to the type: Reconciled status condition?

status:
  conditions:
  - lastTransitionTime: "2023-07-10T09:33:46Z"
    status: "True"
    type: Reconciled
  - lastTransitionTime: "2023-07-10T09:33:49Z"
    message: Application is reconciled and resources are ready.
    status: "True"
    type: Ready
  - lastTransitionTime: "2023-07-10T09:33:49Z"
    message: 'Deployment replicas ready: 1/1'
    reason: MinimumReplicasAvailable
    status: "True"
    type: ResourcesReady
  imageReference: registry.k8s.io/pause:3.2
  references:
    saResourceVersion: "1365018"
    svcCertSecretName: example-runtime-component-svc-tls-ocp
  versions:
    reconciled: 1.2.1

[leochr]

@idlewis that's right

[leochr]

@idlewis Just thought about the visibility to users. The user may not notice the warning if it's inside the Reconciled message - especially when its status condition is 'True'. Adding a new StatusCondition named Warning that includes the warning message(s) would be better. Set the status to 'True' when there is a warning. Omit the StatusCondition or set it to 'False' otherwise.

[idlewis]

@leochr The operator currently only seems to set status conditions from inside ManageError and ManageSuccess. Would those two places stil be the correct place to set this new status condition?

[leochr]

@idlewis Yes, I believe so