Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port warning #560

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Port warning #560

merged 3 commits into from
Apr 18, 2024

Conversation

idlewis
Copy link
Collaborator

@idlewis idlewis commented Jul 12, 2023

@idlewis idlewis self-assigned this Jul 12, 2023
@idlewis idlewis marked this pull request as draft July 12, 2023 14:50
@leochr
Copy link
Member

leochr commented Mar 8, 2024

@idlewis Once you get a chance to check on this PR, please confirm that it's ready for review. Tagging @halim-lee for review when it's ready. Thank you

@leochr leochr requested a review from halim-lee March 8, 2024 16:00
@idlewis idlewis marked this pull request as ready for review April 10, 2024 14:39
@idlewis
Copy link
Collaborator Author

idlewis commented Apr 10, 2024

@halim-lee This is now ready for review.
Test PR is here: https://github.ibm.com/websphere/operators/pull/110/files

Copy link
Collaborator

@halim-lee halim-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Please rebase and merge, thanks!

@idlewis idlewis merged commit 75f8d52 into main Apr 18, 2024
@idlewis idlewis deleted the port-warning branch April 18, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants