Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add set -e -o pipefail in pipeline scripts #312

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

yongja79
Copy link
Contributor

@yongja79 yongja79 commented Nov 2, 2022

Updated several of the build/test scripts so that they would fail on a no zero return code
Signed-off-by: Jason Yong [email protected]

@leochr
Copy link
Member

leochr commented Nov 3, 2022

@davco01a wondering whether OnePipeline would fail the stage if a command (i.e. makefile call, invoking script) returns non-zero or if set -Eeo pipefail or something equivalent should be set for each stage as well (for example here)

This is related to the issue where the failures were silent and not easily visible: https://github.ibm.com/IBMCloudPak4Apps/wshe-OnePipeline/issues/127

@leochr
Copy link
Member

leochr commented Dec 5, 2023

@yongja79 should these changes be ported to the common repo?

@yongja79
Copy link
Contributor Author

yongja79 commented Dec 6, 2023

@leochr I think we probably need to look at this again as the onepipeline scripts have changed significantly since this PR. Alot of the logic is now is separate scripts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants