Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues from PR 277 #280

Merged
merged 7 commits into from
Jun 13, 2024
Merged

Fix issues from PR 277 #280

merged 7 commits into from
Jun 13, 2024

Conversation

dschiese
Copy link
Collaborator

@dschiese dschiese commented Jun 12, 2024

  • fixed query
  • added GitHub action to test maven build on PR's
  • fixed tests#

Refers to #277

dschiese

This comment was marked as outdated.

@anbo-de anbo-de self-assigned this Jun 12, 2024
@anbo-de
Copy link
Member

anbo-de commented Jun 12, 2024

@dschiese
Copy link
Collaborator Author

@dschiese What is the intention of defining default properties here: https://github.com/WDAqua/Qanary/pull/280/files#diff-d00a1105ccfc92a97dee3824ec0b252fc502cad0f28b8f7f3982f71d05fc27a9R135 ?

C.f. #277
It's due to the failing tests. There are some different options to consider:

  1. remove qald_evaluator as dependency (is it needed?)
  2. add the dependencies' required properties (currently)
  3. Run tests from each module

With regards to the 3rd approach: When running the tests for each submodule separately everything works just fine. However, running them from the parent directory fails. Maybe you've got a better solution?

@anbo-de anbo-de merged commit 77fe017 into master Jun 13, 2024
4 checks passed
@anbo-de anbo-de deleted the initializeGraph branch June 13, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants