Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Software curation #2481

Merged
merged 4 commits into from
May 6, 2024
Merged

Software curation #2481

merged 4 commits into from
May 6, 2024

Conversation

Adafede
Copy link
Contributor

@Adafede Adafede commented Apr 20, 2024

Fixes #2480 (issue number, if applicable)

Description

Please include a summary of the change, relevant motivation and context. If possible and applicable, include before and after screenshots and a URL where the changes can be seen.

Based on the pre-existing work about chemicals (https://github.com/WDscholia/scholia/blob/master/scholia/app/templates/chemical-curation_missing-main-subjects.sparql), I added the same for software. There might be more to catch but sounds reasonable as a first step. I mapped them as P4510 only, and not P921

Caveats

Please list anything which has been left out of this PR or which should be considered before this PR is accepted
Check any of the following which apply:

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
    • I have made corresponding changes to the documentation
  • This change requires new dependencies (please list)

If you make changes to the Python code

  • My code passes the tox check, I can receive warnings about tests, documentation or both

Testing

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have not used code from external sources without attribution
  • I have considered accessibility in my implementation
  • There are no remaining debug statements (print, console.log, ...)

@fnielsen fnielsen merged commit f295baf into WDscholia:master May 6, 2024
4 checks passed
@Adafede Adafede deleted the software-curation branch May 6, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing links to softwares in the curation tab
2 participants