Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2545 Make page production query faster #2551

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

fnielsen
Copy link
Collaborator

In the organization aspect the page production query was slow. The new version makes a subquery to identify authors

Fixes #2545

Description

Modify SPARQL query with a WITH subquery

Caveats

Please list anything which has been left out of this PR or which should be considered before this PR is accepted
Check any of the following which apply:

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
    • I have made corresponding changes to the documentation
  • This change requires new dependencies (please list)

If you make changes to the Python code

  • My code passes the tox check, I can receive warnings about tests, documentation or both

Testing

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have not used code from external sources without attribution
  • I have considered accessibility in my implementation
  • There are no remaining debug statements (print, console.log, ...)

In the organization aspect the page production query was slow.
The new version makes a subquery to identify authors
@fnielsen fnielsen self-assigned this Oct 18, 2024
@fnielsen fnielsen merged commit db6f7d2 into master Oct 18, 2024
7 checks passed
@fnielsen
Copy link
Collaborator Author

Now running. Works even for a university such as DTU https://scholia.toolforge.org/organization/Q1269766#page-production

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make page production query faster
1 participant