Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2554 LIMIT retracted works returns #2555

Conversation

fnielsen
Copy link
Collaborator

Add LIMIT to SPARQL query on work index page for recently retracted works.

Fixes #2554

Description

Add LIMIT to SPARQL.
Style in SPARQL

The query and table built-up does not seem to be faster.

Caveats

Please list anything which has been left out of this PR or which should be considered before this PR is accepted
Check any of the following which apply:

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
    • I have made corresponding changes to the documentation
  • This change requires new dependencies (please list)

If you make changes to the Python code

  • My code passes the tox check, I can receive warnings about tests, documentation or both

Testing

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have not used code from external sources without attribution
  • I have considered accessibility in my implementation
  • There are no remaining debug statements (print, console.log, ...)

Add LIMIT to SPARQL query on work index page for recently retracted works.
@egonw egonw self-requested a review November 2, 2024 08:10
@egonw
Copy link
Collaborator

egonw commented Nov 2, 2024

I think this patch is already applied, and not sure why this PR did not get automatically closed.

@egonw egonw closed this Nov 2, 2024
@fnielsen
Copy link
Collaborator Author

fnielsen commented Nov 4, 2024

Now running at https://scholia.toolforge.org/work/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LIMIT the number of recently retracted works from the work index aspect
2 participants