Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #880 issue #2557

Closed
wants to merge 1 commit into from
Closed

fixed #880 issue #2557

wants to merge 1 commit into from

Conversation

Ankush1oo8
Copy link

Fixes #880

Description

This pull request links the "Related" label in the Wembedder section to an informational page. Since no official Wembedder about page exists, the word "Related" now links to the fallback URL: https://arxiv.org/abs/1710.04099. This ensures users get relevant information about Wembedder knowledge graph embeddings.

Before:

  • "Related" label was not clickable.
    After:
  • The label "Related" is now hyperlinked to the fallback page, improving usability.

Caveats

  • If a dedicated Wembedder about page becomes available in the future, this link will need updating.

Check any of the following which apply:

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
    • I have made corresponding changes to the documentation
  • This change requires new dependencies (please list)

If you make changes to the Python code

  • My code passes the tox check, I can receive warnings about tests, documentation or both

Testing

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.

  • Test A: Verified the "Related" link directs users to the correct fallback URL.
  • Test B: Checked that the tooltip and label display correctly without layout issues.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have not used code from external sources without attribution
  • I have considered accessibility in my implementation
  • There are no remaining debug statements (print, console.log, ...)

@fnielsen
Copy link
Collaborator

fnielsen commented Nov 4, 2024

  • After rebasing I get a syntax error (there must be something wrong with the way you tested it)
  • I avoid target="_blank

@Ankush1oo8
Copy link
Author

Okey I will Check

@fnielsen
Copy link
Collaborator

fnielsen commented Nov 5, 2024

I have implemented it with #2561

@fnielsen fnielsen closed this Nov 5, 2024
@fnielsen
Copy link
Collaborator

fnielsen commented Nov 5, 2024

You might want to test your changes before commit and PR. You PR breaks the entire author aspect because of the syntax error.

image

@Ankush1oo8
Copy link
Author

Yes I understand that now I will check more thoroughly next time.

@fnielsen
Copy link
Collaborator

fnielsen commented Nov 5, 2024

Thanks for the PR! We finally put that link in! After five years :) Sorry for not acknowledging you in #2561 I forgot

@Ankush1oo8
Copy link
Author

It's okey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link the word "Related" from the Wembedder section to some Wembedder About page
2 participants