fix: override Array.prototype.map (#567)

also: fix image naming issue causing #562 

closes #562

Author: SlayerOrnstein

build/parser.mjs

@@ -531,7 +531,7 @@ class Parser {
       str
         .replace('/', '')
         .replace(/[ /*]/g, '-')
-        .replace(/[:<>[\]?!]/g, '')
+        .replace(/[:<>[\]?!"]/g, '')
         .toLowerCase();
     const imageStub = image.textureLocation;
     const ext = imageStub.split('.')[imageStub.split('.').length - 1].replace(/\?!.*/, '').replace(/!.*$/, ''); // .png, .jpg, etc

data/img/gauss-prime-theme"redline".png data/img/gauss-prime-themeredline.png

@@ -167,4 +167,16 @@ module.exports = class Items extends Array {
     }
     return A;
   }
+
+  /**
+   * @Override Array.prototype.map
+   *
+   * See filter override
+   */
+  map(fn) {
+    const a = [];
+    for (const el of this) a.push(fn(el));
+
+    return a;
+  }
 };

index.js

@@ -166,4 +166,16 @@ export default class Items extends Array {
     }
     return A;
   }
+
+  /**
+   * @Override Array.prototype.filter
+   *
+   * See filter override
+   */
+  map(fn) {
+    const a = [];
+    for (const el of this) a.push(fn(el));
+
+    return a;
+  }
 }

index.mjs

@@ -268,5 +268,15 @@ for (const base of ['index.js', 'index.mjs']) {
         });
       });
     });
+    it('should not change size when using filter', async () => {
+      const items = await wrapConstr({ category: ['Arch-Gun'] });
+      const realLength = items.length;
+      assert(realLength === items.filter(() => true).length);
+    });
+    it('should not change size when using map', async () => {
+      const items = await wrapConstr({ category: ['Arch-Gun'] });
+      const realLength = items.length;
+      assert(realLength === items.map((x) => x).length);
+    });
   });
 }