Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: override Array.prototype.map #567

Merged
merged 4 commits into from
May 6, 2024
Merged

Conversation

SlayerOrnstein
Copy link
Member

What did you fix?

Same fix as #566 but @Sainan is unable to rebase due to #562


Reproduction steps


Evidence/screenshot/link to line

Considerations

  • Does this contain a new dependency? No
  • Does this introduce opinionated data formatting or manual data entry? No
  • Does this pr include updated data files in a separate commit that can be reverted for a clean code-only pr? No
  • Have I run the linter? Yes
  • Is is a bug fix, feature request, or enhancement? Bug Fix

@SlayerOrnstein SlayerOrnstein requested a review from a team as a code owner May 6, 2024 16:24
@Sainan

This comment was marked as abuse.

@TobiTenno TobiTenno changed the title fix: override Array.prototpye.map fix: override Array.prototype.map May 6, 2024
@TobiTenno
Copy link
Member

we're aware, but you were missing half the implementation

@Sainan

This comment was marked as abuse.

@Sainan

This comment was marked as abuse.

@Sainan

This comment was marked as abuse.

@SlayerOrnstein
Copy link
Member Author

@Sainan
Look thanks for your help and all but it doesn't seem like you're completely aware of how disrespectful you're being. Just because you don't like the language doesn't mean that you can come in shit talk the whole code base.

But what do I know, it's all just data and some JS functions to me.

if you don't understand it then peacefully and respectfully ask how it works. Don't be a child about it and insult it

Like, as far as I can tell, we use your CommonJS module from inside an ES module and that works just fine, so the .mjs just looks superfluous.

Then ask why its A instead of B

If you want to do it your way with whatever language go for it we're not stopping you. If you want to contribute then again go for it but we will not accept them if you continue to be a child about it just because "err I don't like JavaScript". People tried to help you in the discord server but you basiaclly went on an 8hr rant on how JavaScript sucks, how your team plans to move away from warframe-items, and how over complicated it is.

So to get to the point you can either be respectful and be an adult, you can build your own thing, or you can fork it

@Sainan

This comment was marked as abuse.

@SlayerOrnstein
Copy link
Member Author

So completely unaware, got it. So I'm just gonna say this, if you're going to contribute follow the rules set by the repo not "you can merge without rebasing" if you don't want to that's fine you also don't have to contribute

That is the end of this whole conversion, you were told what needed to be told and you refused, anything after this as harsh as it seems falls under harassment

@Sainan

This comment was marked as abuse.

@SlayerOrnstein
Copy link
Member Author

k

@TobiTenno TobiTenno merged commit b4a1e11 into WFCD:master May 6, 2024
8 checks passed
@wfcd-bot-boi
Copy link
Collaborator

🎉 This PR is included in version 1.1262.54 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants