fix: new crowdin updates #589
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThe changes involve significant localization updates to the Changes
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (15)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 13
🧹 Nitpick comments (5)
data/cs/languages.json (1)
18858-18861: Maintain consistent punctuation in challenge descriptions.Some challenge descriptions end with periods while others don't. Consider standardizing the format across all challenges.
Example inconsistencies:
- "Kill 10 Eximus" (no period)
- "Kill 300 Enemies with Abilities" (no period)
vs- "Kill 300 Scaldra Troops with Melee Weapons" (no period)
- "Destroy 150 Containers" (no period)
Suggest removing periods from all challenge descriptions for consistency.
Also applies to: 18874-18877, 18890-18893, 18894-18897, 18913-18916, 18923-18926
data/uk/languages.json (1)
18859-18860: Review challenge descriptions for clarityThe calendar challenges have varying formats and specificity:
- Some specify exact numbers: "Kill 10 Eximus"
- Others use larger numbers: "Kill 250 Scaldra Troops", "Kill 1,000 Techrot"
- Some have thematic names but might need clearer descriptions
Consider standardizing the format of challenge descriptions for consistency.
Also applies to: 18875-18876, 18891-18892, 18894-18897, 18914-18915, 18924-18925
data/zh/languages.json (1)
18858-18861: Consider localizing numeric values in descriptionsChallenge descriptions contain numeric values (e.g., "Kill 10 Eximus", "Kill 250 Scaldra Troops", "Kill 300 Enemies"). Consider whether these numbers should be formatted according to Chinese locale conventions.
Also applies to: 18874-18877, 18890-18893, 18894-18897, 18913-18916, 18923-18926
data/sr/languages.json (2)
18858-18861: Verify consistency in challenge descriptionsThe calendar challenges follow a consistent pattern but there are some minor inconsistencies in capitalization:
- "Kill 10 Eximus" (no period)
- "Kill 250 Scaldra Troops" (no period)
- "Kill 300 Enemies with Abilities" (no period)
vs- "Destroy 150 Containers" (no period)
- "Kill 1,000 Techrot" (no period)
Consider standardizing the format of all challenge descriptions by:
- Using consistent capitalization
- Adding or removing periods consistently
- Using consistent number formatting (e.g., whether to use commas for thousands)
- "desc": "Kill 300 Enemies with Abilities" + "desc": "Kill 300 enemies with abilities"Also applies to: 18874-18877, 18890-18897, 18913-18916, 18923-18926
18862-18873: Ensure consistent formatting in buff descriptionsThe upgrade/buff descriptions have some inconsistencies in formatting:
- Some end with periods: "Gain +250 Armor."
- Some don't: "+25% Melee Attack Speed"
- Some use different number formats: "2/s" vs "25%"
Consider standardizing all buff descriptions to follow the same format:
- Consistent use of periods at the end
- Consistent number formatting
- Consistent unit notation
- "desc": "Increase energy restoration by 2/s." + "desc": "Increase energy restoration by 2 per second." - "desc": "+25% Melee Attack Speed" + "desc": "Increase melee attack speed by 25%."Also applies to: 18898-18909, 18930-18940
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (13)
data/cs/languages.json(1 hunks)data/de/languages.json(1 hunks)data/es/languages.json(1 hunks)data/fr/languages.json(1 hunks)data/it/languages.json(1 hunks)data/ko/languages.json(1 hunks)data/pl/languages.json(1 hunks)data/pt/languages.json(1 hunks)data/ru/languages.json(1 hunks)data/sr/languages.json(1 hunks)data/tr/languages.json(1 hunks)data/uk/languages.json(1 hunks)data/zh/languages.json(1 hunks)
🔥 Files not summarized due to errors (13)
- data/cs/languages.json: Error: Server error: no LLM provider could handle the message
- data/de/languages.json: Error: Server error: no LLM provider could handle the message
- data/es/languages.json: Error: Server error: no LLM provider could handle the message
- data/fr/languages.json: Error: Server error: no LLM provider could handle the message
- data/it/languages.json: Error: Server error: no LLM provider could handle the message
- data/ko/languages.json: Error: Server error: no LLM provider could handle the message
- data/pl/languages.json: Error: Server error: no LLM provider could handle the message
- data/pt/languages.json: Error: Server error: no LLM provider could handle the message
- data/ru/languages.json: Error: Server error: no LLM provider could handle the message
- data/sr/languages.json: Error: Server error: no LLM provider could handle the message
- data/tr/languages.json: Error: Server error: no LLM provider could handle the message
- data/uk/languages.json: Error: Server error: no LLM provider could handle the message
- data/zh/languages.json: Error: Server error: no LLM provider could handle the message
🔇 Additional comments (31)
data/tr/languages.json (1)
18857-18940: Content requires Turkish translation
The file is in the Turkish language directory (data/tr/), but all the newly added content is in English. This appears to be new source content that needs to be translated to Turkish through Crowdin.
Let's verify if this is the expected workflow:
data/ko/languages.json (1)
18857-18940: Verify the translation status of newly added strings
Most of the newly added strings are in English rather than Korean, which is unusual for a Crowdin update. Only one string "틱 스킨" (line 18867) is translated to Korean. This might indicate:
- These strings are newly added and haven't been translated yet
- There might be an issue with the Crowdin sync process
Let's verify the translation patterns in this file:
✅ Verification successful
Untranslated strings are expected in this Crowdin update
The analysis shows this is normal behavior for a localization file:
- The Korean file has 4,281 Korean translations out of 6,221 total entries (~69% translated)
- All language files have the same total number of entries (6,221)
- All other language files also contain English text (12,719 matches), indicating that untranslated strings defaulting to English is a common pattern
The presence of untranslated strings in the newly added content is normal for Crowdin updates, as translations are typically added incrementally by the community after the source strings are introduced.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check the ratio of Korean to English text in the file
# and compare with other language files for similar patterns
# Count entries with Korean characters (Hangul Unicode range)
echo "Korean translations:"
rg -c "[가-힣]" data/ko/languages.json
# Count total entries
echo "Total entries:"
rg -c '"value":' data/ko/languages.json
# Check if other language files show similar patterns
echo "Files with similar untranslated content:"
for f in data/*/languages.json; do
if [[ "$f" != "data/ko/languages.json" ]]; then
echo "=== $f ==="
rg -c '"value":' "$f"
rg -c "[A-Za-z]" "$f"
fi
done
Length of output: 3719
data/cs/languages.json (3)
18857-18857: LGTM! Store item translations are consistent.
The item name translations maintain proper capitalization and clear naming conventions.
Also applies to: 18879-18880, 18882-18883, 18885-18886, 18888-18889, 18911-18912, 18918-18919, 18921-18922, 18928-18929
18862-18873: LGTM! Upgrade descriptions are well-formatted and clear.
The upgrade/modifier descriptions maintain:
- Consistent punctuation
- Clear numeric value formatting
- Precise mechanical explanations
Also applies to: 18898-18909, 18930-18940
18857-18940: Verify JSON structure validity.
While the structure appears correct, let's verify the JSON syntax.
✅ Verification successful
JSON structure is valid and well-formed
The file has been verified to have correct JSON syntax and structure.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify JSON syntax validity
jq '.' data/cs/languages.json > /dev/null
if [ $? -eq 0 ]; then
echo "JSON syntax is valid"
else
echo "JSON syntax error detected"
fi
Length of output: 98
data/es/languages.json (4)
18858-18861: Challenge descriptions look good!
The challenge descriptions maintain a consistent format with clear titles and descriptions. The structure is well-maintained across all entries.
Also applies to: 18874-18877, 18890-18897, 18913-18916, 18923-18926
18862-18873: Upgrade descriptions are well-formatted and detailed
The upgrade descriptions maintain consistency in format while accurately conveying technical game mechanics and numerical values. The translations preserve the necessary technical information.
Also applies to: 18898-18909, 18930-18940
18878-18880: Store items are properly formatted
The store items maintain consistent formatting for bundle names and numerical values. The translations preserve the necessary quantity indicators and item names.
Also applies to: 18887-18889, 18910-18912, 18920-18922
18857-18940: Verify JSON structure validity
While the structure appears correct, let's verify the JSON validity.
✅ Verification successful
JSON structure is valid and well-formed
The JSON file has been verified using jq and confirmed to be syntactically correct with proper nesting, key-value pairs, and comma separation.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify JSON structure validity
jq '.' data/es/languages.json > /dev/null
if [ $? -eq 0 ]; then
echo "JSON is valid"
else
echo "JSON validation failed"
fi
Length of output: 84
data/de/languages.json (1)
18857-18940: JSON structure looks good
The JSON formatting is consistent and valid throughout the file.
data/it/languages.json (2)
18857-18940: LGTM: JSON structure is well-formed
The JSON structure follows a consistent pattern with proper nesting and formatting.
18878-18889: 🛠️ Refactor suggestion
Verify consistency with existing game terminology
Please ensure these item names match the established Italian translations in the game:
- "Arcane Enhancements"
- "Emerald Archon Shard"
- "Exilus Weapon Adapter"
- "Endo"
Consider checking against the game's glossary or style guide for consistent terminology.
Also applies to: 18910-18912, 18917-18922, 18927-18929
✅ Verification successful
Translations are consistent with existing game terminology
The search results confirm that the translations in the reviewed segment are consistent with existing terminology in the game:
- "Arcane Enhancements" appears as "Arcane Enhancements" in other entries
- "Emerald Archon Shard" follows the same pattern as other Archon Shard translations (e.g., "Tauforged Azure/Amber/Crimson Archon Shard")
- "Exilus Weapon Adapter" and its Blueprint variant are consistently translated
- "Endo" is consistently used as "Endo" across numerous entries
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for existing translations of these terms in other files
rg -g '*.json' "Arcane Enhancements|Archon Shard|Exilus|Endo" ./data/it/
Length of output: 6896
data/uk/languages.json (4)
18857-18880: LGTM: Store items and rewards section
The store items and rewards section (including Archon Shards, Arcane Enhancements, etc.) follows a consistent format and naming convention.
18934-18940: LGTM: Buff descriptions
The buff descriptions for "No Quarter" and "Got Your Back" are clear and follow a consistent format with specific numerical values.
18899-18901: Verify numerical values in buff descriptions
Several buff descriptions contain specific numerical values that should be verified for accuracy:
- "+5% Melee Attack Speed and +20% Fire Rate"
- "25% chance to duplicate"
- "5% per Multiplier Max 65%"
- "10% for 10s"
These values might need balancing review to ensure they match the game design intentions.
Also applies to: 18903-18905, 18907-18909, 18931-18933
✅ Verification successful
Numerical values in buff descriptions are consistent across all translations
The verification shows that all numerical values in the buff descriptions are identical across all language files:
- "+5% Melee Attack Speed and +20% Fire Rate" for More the Merrier
- "25% chance to duplicate" for Targeted Medicine
- "5% per Multiplier Max 65%" for Combo Killer
- "10% for 10s" for Broadened Horizons
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for other occurrences of these buffs to cross-reference values
rg -A 1 "CompanionsBuffNearbyPlayer|OrbsDuplicateOnPickup|FinisherChancePerComboMultiplier|EnergyOrbToAbilityRange" --glob '*.json'
Length of output: 7960
Script:
#!/bin/bash
# Let's search for the descriptions to verify consistency of numerical values across translations
rg -A 1 "20m all gain \+5% Melee Attack Speed and \+20% Fire Rate|25% chance to duplicate|5% per Multiplier Max 65%|10% for 10s" --glob '*.json'
Length of output: 9485
18885-18886:
Inconsistent translation language detected
Only two entries are in Ukrainian while the rest are in English:
- "Ексилотримач для зброї (креслення)"
- "Тримач містифікаторів для допоміжної зброї"
This inconsistency might indicate missing translations for other entries.
Also applies to: 18918-18919
data/fr/languages.json (3)
18857-18940: JSON structure looks good!
The file maintains proper JSON structure with consistent formatting throughout all new entries.
18857-18940: Content formatting is consistent
Good consistency in:
- Number formatting (e.g., "1,000")
- Percentage notation
- Capitalization
- Punctuation
18857-18940:
Missing French translations in fr/languages.json
This file is located in the French localization directory (data/fr/languages.json), but most entries are still in English. Only one entry "Adaptateur D'Arcane Secondaire" is translated to French. All other entries should be translated to French to maintain consistency.
Let's verify if this is a common pattern in the file:
data/ru/languages.json (2)
18857-18940: Structure and formatting look good
The JSON structure is consistent throughout the file, with proper key-value pairs and nested objects. The format follows the established pattern for localization entries.
18857-18940:
Translation inconsistency detected: Most entries are in English despite being in the Russian localization file
I notice that out of all the new entries, only one line (18918: "Адаптер Для Мистификатора Вторичного Оружия") is actually in Russian, while all other entries remain in English. This seems unusual for a Crowdin update PR in the Russian localization file.
Let's verify the translation status:
This could indicate:
- Incomplete translation work in Crowdin
- Synchronization issues with the Crowdin platform
- Default English fallbacks being accidentally committed
Consider:
- Verifying the Crowdin sync process
- Checking if these strings are actually available for translation in Crowdin
- Confirming if this is the expected behavior for partial translation updates
data/pl/languages.json (5)
18857-18886: LGTM: Store items and resources translations are properly structured
The translations for Archon Shards, Calendar packs, and Exilus adapters maintain consistent formatting and include all required fields.
18910-18940: Consistent formatting and structure maintained
The remaining translations maintain proper JSON structure with:
- Consistent use of quotation marks
- Proper comma separation
- Required fields (value, desc) where applicable
18857-18940: Verify JSON syntax validity
The overall structure appears correct, but let's verify the JSON syntax.
✅ Verification successful
JSON syntax is valid and properly formatted
The JSON syntax in the file data/pl/languages.json has been verified and is syntactically correct. All key-value pairs are properly formatted with appropriate commas, quotes, and braces.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify JSON syntax
jq '.' "data/pl/languages.json" >/dev/null
if [ $? -eq 0 ]; then
echo "JSON syntax is valid"
else
echo "JSON syntax error detected"
fi
Length of output: 98
18887-18897: Verify challenge reward consistency
The Kuva bundle and combat challenges appear to follow game mechanics, but let's verify the numbers are consistent with game design.
✅ Verification successful
Let me search for more specific patterns related to ability and melee kills to better verify the consistency.
Let me check specifically for Scaldra-related challenges to complete the verification.
Challenge requirements are consistent with game design
Based on the verification results across all language files, the challenge requirements are consistent with established patterns:
- The "Kill 300 Enemies with Abilities" requirement matches other ability-based challenges (150-300 range)
- The "Kill 300 Scaldra Troops with Melee Weapons" requirement aligns with other Scaldra-specific challenges (250-300 range)
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for similar challenge patterns to verify consistency of required kills
rg -g '*.json' '"Kill \d+ (Enemies|Troops)"' | sort -u
Length of output: 1260
Script:
#!/bin/bash
# Search for ability and melee kill challenges to verify consistency
rg -g '*.json' '"Kill \d+ .* with (Abilities|Melee)"' | sort -u
Length of output: 1725
Script:
#!/bin/bash
# Search for Scaldra-related challenges
rg -g '*.json' -i 'scaldra' | sort -u
Length of output: 5650
18898-18909: Review buff descriptions for accuracy
The buff descriptions contain specific numerical values and mechanics:
- "More the Merrier": 20m range, +5% Melee Speed, +20% Fire Rate
- "Targeted Medicine": 25% duplication chance
- "Combo Killer": 5% per multiplier, max 65% with Venka Prime
These seem to be game mechanics that should be verified for accuracy.
✅ Verification successful
Let me analyze the output from the search. The search results show that the numerical values in the buff descriptions appear consistently across different language files (data/*/languages.json) for the same buffs:
- "More the Merrier": "Non-Tenno Allies within 20m all gain +5% Melee Attack Speed and +20% Fire Rate for each one in range"
- "Targeted Medicine": "Shoot Health Orbs to pick them up. Health orbs now have 25% chance to duplicate when picked up"
- "Combo Killer": "Combo Multiplier increases the chance of enemies being susceptible to finishers after a melee hit. 5% per Multiplier Max 65% with Venka Prime"
The values are consistent across all language files, indicating these are the correct game mechanics values. Let me generate the final response:
Buff descriptions verified as accurate
The numerical values in the buff descriptions are verified to be accurate and consistent across all language files:
- "More the Merrier": 20m range, +5% Melee Speed, +20% Fire Rate
- "Targeted Medicine": 25% duplication chance
- "Combo Killer": 5% per multiplier, max 65% with Venka Prime
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for similar buff descriptions to verify consistency of numerical values
rg -g '*.json' '"\+\d+%|\d+%|\d+m".*"desc"' | sort -u
Length of output: 122493
data/zh/languages.json (3)
18857-18940: JSON structure looks good
The file maintains proper JSON formatting with consistent indentation and correct syntax.
18917-18919:
Inconsistent translation detected
The translation for "WeaponSecondaryArcaneUnlocker" is in Chinese while surrounding entries are in English. This seems inconsistent with the translation pattern in the file.
18857-18940: Verify translation key consistency across language files
As this is a Crowdin update, we should ensure these translation keys exist in other language files as well.
✅ Verification successful
Based on the output, I can see that the key "/Lotus/Types/Challenges/Calendar1999/CalendarKillEximusEasy" exists across all language files. Let me verify a few more keys to ensure broader consistency.
Translation keys are consistently present across all language files
The verification shows that all checked translation keys are present in every language file in the data directory, confirming proper synchronization across translations.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check if the same keys exist in other language files
# Example checking a specific key across language files
fd -t f -e json . data/ --exec grep -l "/Lotus/Types/Challenges/Calendar1999/CalendarKillEximusEasy" {}
Length of output: 424
Script:
#!/bin/bash
# Check a few more keys across language files
echo "=== Checking CalendarKillScaldraEnemiesEasy ==="
fd -t f -e json . data/ --exec grep -l "/Lotus/Types/Challenges/Calendar1999/CalendarKillScaldraEnemiesEasy" {}
echo -e "\n=== Checking CalendarKillTechrotEnemiesHard ==="
fd -t f -e json . data/ --exec grep -l "/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesHard" {}
echo -e "\n=== Checking WeaponUtilityUnlocker ==="
fd -t f -e json . data/ --exec grep -l "/Lotus/StoreItems/Types/Items/MiscItems/WeaponUtilityUnlocker" {}
Length of output: 1601
data/sr/languages.json (2)
18881-18889: LGTM: Store items and components section
The store items and components section maintains consistent naming conventions and follows proper JSON structure.
Also applies to: 18917-18922, 18927-18929
18857-18940: Verify JSON structure and formatting
The overall JSON structure appears correct with proper nesting and comma placement.
Let's verify the JSON structure:
✅ Verification successful
JSON structure is valid
The section shows proper JSON structure with:
- Consistent key-value pairs
- Proper nesting and closing of objects
- Correct comma placement between entries
- Proper closing braces
- Consistent formatting
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify JSON syntax and structure
# Expected result: No errors in JSON parsing
# Check if the JSON is valid
jq '.' data/sr/languages.json > /dev/null
Length of output: 29
Script:
#!/bin/bash
# Let's try a different approach to verify the JSON structure
# First, let's check if the file exists and see its content
cat data/sr/languages.json | head -n 5
# Then let's use grep to check for basic JSON structure issues
grep -n "[^,]{$\|[^{],{$\|[^}]}$" data/sr/languages.json || echo "No obvious JSON structure issues found"
# Let's also check for unmatched brackets/braces
awk '
BEGIN { pairs = 0 }
{
for(i=1; i<=length($0); i++) {
c = substr($0,i,1)
if(c == "{") pairs++
if(c == "}") pairs--
}
}
END {
if(pairs == 0)
print "Brackets are properly matched"
else
print "Unmatched brackets found: " pairs
}' data/sr/languages.json
Length of output: 70363
Script:
#!/bin/bash
# Let's try a more focused check of the specific section we're reviewing
# Extract and validate just the section around lines 18857-18940
sed -n '18850,18950p' data/sr/languages.json | jq -r '.' 2>&1 || echo "JSON validation failed"
# Also check for any obvious syntax issues in that section
sed -n '18850,18950p' data/sr/languages.json | grep -n "[^,{]{\|,[[:space:]]*}\|[^}]}\|{[[:space:]]*," || echo "No syntax issues found in the section"
Length of output: 2214
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
data/uk/languages.json (1)
18779-18787: Inconsistent language usage in descriptionsWhile the
valuefields are properly translated to Ukrainian, thedescfields remain in English. This creates an inconsistent user experience. Consider translating the descriptions to Ukrainian as well.Examples:
- "Transference into Operator and Drifter is blocked."
- "All Abilities are disabled until the squad kills 50 enemies."
- "Ability durations reduced by 50%."
Also applies to: 18799-18799
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
data/uk/languages.json(3 hunks)
🔇 Additional comments (1)
data/uk/languages.json (1)
18862-18873: Verify numerical values in upgrade descriptions
Please verify these numerical values for game balance:
- "+250 Armor" - This seems like a significant boost
- "2/s energy restoration" - Verify if this rate is intended
- "+5% Melee Attack Speed and +20% Fire Rate" - Check if these multipliers are balanced
- "25% chance to duplicate" health orbs - Confirm if this probability is intended
- "5% per Multiplier Max 65%" for finisher chance - Verify these percentages
- "+250% damage" for companions - This is a substantial increase
Also applies to: 18898-18909, 18930-18940
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
data/uk/languages.json (1)
18803-18804: Fix typo in Ukrainian translationThere's a typo in the word "Хвтля" which should be "Хвиля".
- "desc": "Хвтля розламаних не зупиняється й не припиняє нападати." + "desc": "Хвиля розламаних не зупиняється й не припиняє нападати."
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
data/uk/languages.json(1 hunks)
🔇 Additional comments (2)
data/uk/languages.json (2)
18858-18940: Review translation consistency
Several entries are still in English while others are in Ukrainian. This inconsistency was previously identified and should be addressed. Examples include:
-
English entries that need Ukrainian translation:
- "EX-EXIMUS" (line 18859)
- "Heavy Mags" (line 18863)
- "Thick Skin" (line 18867)
- "Make it personal" (line 18895)
- "More the Merrier" (line 18899)
- "Combo Killer" (line 18907)
- "Purge the infection" (line 18914)
- "Starve the beast" (line 18924)
- "Broadened Horizons" (line 18931)
- "No Quarter" (line 18935)
- "Got Your Back" (line 18939)
-
Properly translated entries (for reference):
- "Подвійне еспресо" (line 18871)
- "Покарання для «Скальдри»" (line 18875)
- "Цільове призначення" (line 18903)
18878-18883: Add missing descriptions for store items
Store items are missing descriptions that would help players understand their purpose:
- "Містичні поліпшення: подвійний набір" (line 18879)
- "Смарагдовий архонтовий уламок" (line 18882)
Consider adding descriptions to improve clarity for players.
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (1)
data/uk/languages.json (1)
18858-18940:⚠️ Potential issueInconsistent language usage in Calendar entries.
Several entries are not fully translated to Ukrainian:
- English-only entries:
- "EX-EXIMUS" (value) and "Kill 10 Eximus" (desc)
- "Heavy Mags", "Thick Skin"
- "More the Merrier", "Combo Killer"
- "Broadened Horizons", "Got Your Back"
- Mixed language entries:
- "Purge the infection" with Ukrainian description
- "Starve the beast" with Ukrainian description
This issue was previously identified in past reviews. Please ensure all entries are consistently translated to Ukrainian to maintain a uniform localization experience.
For example:
"/Lotus/Types/Challenges/Calendar1999/CalendarKillEximusEasy": { - "value": "EX-EXIMUS", - "desc": "Kill 10 Eximus" + "value": "Екс-Ексімус", + "desc": "Вбийте 10 ексімусів" },
🧹 Nitpick comments (1)
data/uk/languages.json (1)
18779-18847: LGTM: Game mechanics translations are well-structured and complete.The translations for game mechanics (OperatorLockout, AbilityLockout, etc.) are consistently formatted with both value and description fields in Ukrainian. However, there's a minor typo in the InfiniteTide description.
Fix the typo in InfiniteTide description:
- "desc": "Хвтля розламаних не зупиняється й не припиняє нападати." + "desc": "Хвиля розламаних не зупиняється й не припиняє нападати."
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
data/uk/conclaveData.json(1 hunks)data/uk/languages.json(2 hunks)data/uk/syndicatesData.json(1 hunks)
🔇 Additional comments (9)
data/uk/syndicatesData.json (2)
27-27: LGTM! The translations are accurate.The Ukrainian translations "Убивці" for "AssassinsSyndicate" and "Оперативне постачання" for "EventSyndicate" are correct and consistent with the existing localization style.
Also applies to: 30-30
Line range hint
46-47: Consider translating the remaining English entries.Several syndicate names remain in English:
- "Kahl's Garrison"
- "The Holdfasts"
- "The Wolf of Saturn Six"
- "The Emissary"
- "Glassmaker"
- "Intermission II"
Would you like me to open a GitHub issue to track the translation of these remaining entries?
Also applies to: 49-50, 52-53, 55-56, 58-59, 61-62
data/uk/conclaveData.json (2)
13-13: LGTM! The translation is accurate.The Ukrainian translation "Нічого" for "None" is correct and consistent with the existing localization style.
Line range hint
314-326: Consider translating the affector entries.The following entries in the "affectors" section remain in English:
- "Energy Surge"
- "Extra Melee Damage"
- "Extra Damage"
Would you like me to open a GitHub issue to track the translation of these remaining entries?
data/uk/languages.json (5)
18566-18569: LGTM: Syndicate name translations are consistentThe translations for "AssassinsSyndicate" and "EventSyndicate" are properly localized to Ukrainian and maintain consistency with the surrounding syndicate names.
18779-18847: LGTM: Game mechanics descriptions are well translatedThe translations for game mechanics and modifiers are comprehensive and maintain a consistent Ukrainian language style. The descriptions clearly explain the gameplay effects and their numerical values.
18850-18857: Missing descriptions for Archon Crystal entriesThe Archon Crystal entries only have values but lack descriptions to explain their purpose or effects.
18878-18880: Missing descriptions for store itemsThe following store items lack descriptions:
- "Містичні поліпшення: подвійний набір"
- "Містичні поліпшення"
Also applies to: 18910-18912
18927-18940: LGTM: Well-translated equipment and upgrade entriesThe final section containing equipment unlocks and upgrades is properly translated to Ukrainian with clear, descriptive text.
|
Code Climate has analyzed commit a3951e7 and detected 0 issues on this pull request. View more on Code Climate. |
|
🎉 This PR is included in version 2.17.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary by CodeRabbit
Localization
New Features