Add note as annotationType #971
Conversation
path of least resistance to getting valid pbcore in Zipped ingester for remainder of Minnesota records with "Note" annotationType
There was a problem hiding this comment.
In addition to the indentation fixes... are we sure we want to add this type?
To add an annotation of type "note" seems a little redundant (annotations are notes), and also like it may be leaning into a well known anti-pattern of putting specific things into a generic notes field. This has been an issue with every database I've ever worked with -- when the schema falls short, the notes fields get overused.
There is also the annotations without any value for annotationType, which I think was what we were using for adding a generic "note" via pbcoreAnnotation. So if we now have a pbcoreAnnotation with annotationType="note", we may actually be introducing a 2nd place for putting generic notes.
|
|
||
| def note | ||
| note ||= find_annotation_attribute("note") | ||
| end |
There was a problem hiding this comment.
Unindent end by one space to match it's opening def (same for ams1_legacy_metadata above, and any other place you might see where they are unaligned).
|
|
||
| def note | ||
| note ||= find_annotation_attribute("note") | ||
| end |
There was a problem hiding this comment.
match indentation of def and end
PR to add "Note" as a valid annotationType specifically for PBCore Zipped ingest. This is to allow 68K minnesota records to be ingested that had multiple invalid annotationTypes that we have merged into a single "Note" annotationType