Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"subscribe to an": use |observer| instead of [=this=] #163

Closed
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
"subscribe to an": use |observer| instead of [=this=]
keithamus committed Jul 26, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 6e1697a6422229cf257b61f975a30278060ee62a
6 changes: 3 additions & 3 deletions spec.bs
Original file line number Diff line number Diff line change
@@ -455,7 +455,7 @@ An <dfn>internal observer</dfn> is a [=struct=] with the following [=struct/item
bindings on objects whose properties could be mutated by JavaScript. See
[[#promise-returning-operators]] for usage of this.

1. If [=this=]'s [=relevant global object=] is a {{Window}} object, and its [=associated
1. If |observer|'s [=relevant global object=] is a {{Window}} object, and its [=associated
Document=] is not [=Document/fully active=], then return.

1. Let |internal observer| be a new [=internal observer=].
@@ -534,13 +534,13 @@ An <dfn>internal observer</dfn> is a [=struct=] with the following [=struct/item

1. [=close a subscription|Close=] |subscriber|.

1. If [=this=]'s [=Observable/subscribe callback=] is a {{SubscribeCallback}}, [=invoke=] it
1. If |observer|'s [=Observable/subscribe callback=] is a {{SubscribeCallback}}, [=invoke=] it
with |subscriber|.

If <a spec=webidl lt="an exception was thrown">an exception |E| was thrown</a>, call
|subscriber|'s {{Subscriber/error()}} method with |E|.

1. Otherwise, run the steps given by [=this=]'s [=Observable/subscribe callback=], given
1. Otherwise, run the steps given by |observer|'s [=Observable/subscribe callback=], given
|subscriber|.
</div>