Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MathML defaults #250

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

MathML defaults #250

wants to merge 2 commits into from
+71 −3

Conversation

otherdaniel
Copy link
Collaborator

@otherdaniel otherdaniel commented Jan 15, 2025 •
edited by pr-preview bot
Loading

MathML default safelist, based on dicussion in #103.

Preview | Diff

@otherdaniel
Copy link
Collaborator Author

This is based on top of PR #244, which the review UI apparently doesn't expect. For now, please look at only the last commit. :-/

@otherdaniel otherdaniel mentioned this pull request Jan 15, 2025
Open
annevk
annevk reviewed Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spotted what I think are mistakes. Looks okay otherwise.

builtins/safe-default-configuration.txt Outdated Show resolved Hide resolved
@mozfreddyb mozfreddyb requested a review from annevk January 16, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mozfreddyb mozfreddyb mozfreddyb approved these changes

@annevk annevk annevk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@otherdaniel @annevk @mozfreddyb