Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Remove remaining references to scheduler.yield options #105

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

brendankenny
Copy link
Contributor

@brendankenny brendankenny commented Aug 22, 2024

following removal in #100, presumably these need to go too

(Incidentally, bikeshed errors for me, but I eventually found speced/bikeshed#2621 which fixes the link error for me too. Somehow the github action is working, though? 🤷)


Preview | Diff

@brendankenny brendankenny changed the title Remove remaining references to scheduler.yield options Editorial: remove remaining references to scheduler.yield options Aug 22, 2024
@brendankenny brendankenny changed the title Editorial: remove remaining references to scheduler.yield options Editorial: Remove remaining references to scheduler.yield options Aug 22, 2024
Copy link
Collaborator

@shaseley shaseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@w3cbot
Copy link

w3cbot commented Aug 22, 2024

shaseley marked as non substantive for IPR from ash-nazg.

@shaseley
Copy link
Collaborator

(Incidentally, bikeshed errors for me, but I eventually found speced/bikeshed#2621 which fixes the link error for me too. Somehow the github action is working, though? 🤷)

Interesting -- old version maybe? At some point after filing that, things started working again, both locally and for the preview.

@shaseley shaseley merged commit 00a8773 into WICG:main Aug 22, 2024
2 checks passed
@brendankenny brendankenny deleted the noyieldoptions branch August 22, 2024 20:16
@brendankenny
Copy link
Contributor Author

Interesting -- old version maybe? At some point after filing that, things started working again, both locally and for the preview.

Ugh, yeah, that's exactly what it was. venv and pipx not playing well together and running a version from last year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants