Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yield: Add null check for inherited state in spec #107

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

shaseley
Copy link
Collaborator

@shaseley shaseley commented Sep 16, 2024

"schedule a yield continuation" was not taking into account that the current scheduling state can be null, in which case the priority source and abort source are null, and a non-abortable, user-visible continuation should be scheduled. The latter is handled already by the abort and priority source null checks, but these weren't being initialized to null if the inherited scheduling state is null.

Fixes #106


Preview | Diff

@shaseley shaseley merged commit ec14f7d into WICG:main Sep 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What should happen if yield is called when then event loop's current scheduling state is null?
2 participants