Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an edge case with join / win history #1364

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+19 −9
Open

Fix an edge case with join / win history #1364

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b4ee30
Fix an edge case with join / win history
caraitto Dec 12, 2024
e0e73d5
Merge branch 'main' of github.com:WICG/turtledove into fix-join-bid-h…
caraitto Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions spec.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1757,11 +1757,11 @@ following steps. They return a failure if failing to fetch the script or wasm, o
1. Let |igGenerateBid| be the result of [=building an interest group passed to generateBid=] with
|ig|.
1. Set |browserSignals|["{{BiddingBrowserSignals/joinCount}}"] to the sum of |ig|'s
[=interest group/join counts=] for all days within the last 30 days.
[=interest group/join counts=] for all days within the last 31 days in UTC, inclusive.
1. Set |browserSignals|["{{BiddingBrowserSignals/recency}}"] to the [=current coarsened wall
time=] minus |ig|'s [=interest group/join time=], in milliseconds.
1. [=map/Set=] |browserSignals|["{{BiddingBrowserSignals/bidCount}}"] to the sum of |ig|'s
[=interest group/bid counts=] for all days within the last 30 days.
[=interest group/bid counts=] for all days within the last 31 days in UTC, inclusive.
1. [=map/Set=] |browserSignals|["{{BiddingBrowserSignals/adComponentsLimit}}"] to 40.
1. [=map/Set=] |browserSignals|["{{BiddingBrowserSignals/multiBidLimit}}"] to |multiBidLimit|.
1. Let |prevWins| be a new <code>[=sequence=]<{{PreviousWin}}></code>.
Expand Down Expand Up @@ -3452,11 +3452,17 @@ A <dfn>server auction interest group</dfn> is a [=struct=] with the following [=
A <dfn>server auction browser signals</dfn> is a [=struct=] with the following [=struct/items=]:
<dl dfn-for="server auction browser signals">
: <dfn>bid count</dfn>
:: A count of the number of bids for this interest group in the last 30 days.
Calculated by summing the [=interest group/bid counts=] for all days within the last 30 days.
:: A count of the number of bids for this interest group in the last 31 days.
Calculated by summing the [=interest group/bid counts=].

NOTE: An additional day is added (31 vs. 30 days) to ensure that history is kept for at least as
long as the max group lifetime, since bid counts are kept by UTC day.
: <dfn>join count</dfn>
:: A count of the number of joins for this interest group in the last 30 days.
:: A count of the number of joins for this interest group in the last 31 days, inclusive.
Calculated by summing the [=interest group/join counts=].

NOTE: An additional day is added (31 vs. 30 days) to ensure that history is kept for at least as
long as the max group lifetime, since join counts are kept by UTC day.
: <dfn>recency ms</dfn>
:: A [=duration=], in milliseconds, representing the [=current coarsened wall time=] at
the time this object was constructed minus the corresponding [=interest group=]'s
Expand Down Expand Up @@ -3651,9 +3657,11 @@ The <dfn for=Navigator method>getInterestGroupAdAuctionData(|configIDL|)</dfn> m
1. [=list/Append=] |serverPrevWin| to |prevWins|.
1. Let |browserSignals| be a new [=server auction browser signals=] with the following [=struct/items=]:
: [=server auction browser signals/bid count=]
:: the sum of |ig|'s [=interest group/bid counts=] with a bid day within the last 30 days
:: the sum of |ig|'s [=interest group/bid counts=] with a bid day within the last 31 days,
inclusive.
: [=server auction browser signals/join count=]
:: the sum of |ig|'s [=interest group/join counts=] with a join day within the last 30 days
:: the sum of |ig|'s [=interest group/join counts=] with a join day within the last 31 days,
inclusive.
: [=server auction browser signals/recency ms=]
:: the [=current coarsened wall time=] minus |ig|'s [=interest group/join time=] in
millseconds
Expand Down Expand Up @@ -4978,8 +4986,10 @@ dictionary StorageInterestGroup : AuctionAdInterestGroup {
1. Let |encoded| be the result of running [=forgiving-base64 encode=] with |ig|'s [=interest group/additional bid key=].
1. If |encoded| is failure, then return failure.
1. [=map/Set=] |resultIg|["{{AuctionAdInterestGroup/additionalBidKey}}"] to the result of running [=forgiving-base64 encode=] with |ig|'s [=interest group/additional bid key=].
1. [=map/Set=] |resultIg|["{{StorageInterestGroup/joinCount}}"] to the sum of |ig|'s [=interest group/join counts=] for all days within the last 30 days.
1. [=map/Set=] |resultIg|["{{StorageInterestGroup/bidCount}}"] to the sum of |ig|'s [=interest group/bid counts=] for all days within the last 30 days.
1. [=map/Set=] |resultIg|["{{StorageInterestGroup/joinCount}}"] to the sum of |ig|'s [=interest
group/join counts=] for all days within the last 31 days, inclusive.
1. [=map/Set=] |resultIg|["{{StorageInterestGroup/bidCount}}"] to the sum of |ig|'s [=interest
group/bid counts=] for all days within the last 31 days, inclusive.
1. Let |resultPrevWins| be a new <code>[=sequence=]<{{PreviousWin}}></code>.
1. [=list/For each=] |prevWin| of |ig|'s [=interest group/previous wins=] for all days within the
the last 30 days:
Expand Down
Loading