Spec'ing creative scanning via BYOS/V1 trusted scoring signals #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
February 11, 2025 13:09
morlovich
changed the title
orrb1
reviewed
Feb 13, 2025
orrb1
approved these changes
Feb 14, 2025
| |queryParamsList|. | ||
|
|
||
| Note: this works differently from other query parameters since it has a comma that we do not | ||
| want to escape, and other characters are known not to require it. |
There was a problem hiding this comment.
s/and other characters are known not to require it/and none of the other characters used to represent the width and height of each ad need to be escaped either?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes trusted scoring signals params escaping in general to not escape commas
when not expected.
See #792 (comment)
and latter comments on that issue for more context.
Preview | Diff