-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for ad component reportEvent #541
Conversation
@xiaochen-z can you link your github account with your w3c account so the IPR bot will be happy? See https://www.w3.org/users/myprofile/connectedaccounts - thanks! |
Done, I've linked my account. It seems I also need to join the Web Platform Incubator Community Group. I've sent the request using the link. |
Awesome, IPR is good now. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm % some comments, thanks!
Updated FenceEvent's IDL to make eventData field optional. 1. No eventData: beacon is sent with an empty string for the eventData field. window.fence.reportEvent({ eventType: 'click', destination: ['buyer'] }); 2. Has eventData: beacon is sent with the given string for the eventData field. window.fence.reportEvent({ eventType: 'click', eventData: 'this is a click', destination: ['buyer'] }); Pull request for updating the explainer: WICG/turtledove#541 Bug: 1394499 Change-Id: I48d5554d0cc6b3ae56b161bca86fa65bffc2080f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4386613 Commit-Queue: Xiaochen Zhou <[email protected]> Reviewed-by: Caleb Raitto <[email protected]> Reviewed-by: Dominic Farolino <[email protected]> Code-Coverage: Findit <[email protected]> Cr-Commit-Position: refs/heads/main@{#1134909}
Co-authored-by: Paul Jensen <[email protected]>
Mention click as an example for user activation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm % nit
SHA: fe032ac Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: fe032ac Reason: push, by qingxinwu Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Update the explainer for support for ad component reportEvent #332.