Ruff Adoption & Linting Reset #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RHammond2
added
enhancement
nRiccobo
reviewed
Jun 26, 2024
nRiccobo
reviewed
Jun 26, 2024
nRiccobo
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes pylint and flake8 from the linting stack, and adopts ruff in its place. This switch
This PR also cleans the slate for using pre-commit without issue, so users should not be using the
--no-verifyflag anymore to ignore all the errors that have been ignored before their contributions.It may be helpful to run
git config blame.ignoreRevsFile .git-blame-ignore-revsto ensure the massive commit that deals the majority of this linting cleanup doesn't show up in the git blame messages.