Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dockerfile #21

Merged
merged 1 commit into from
May 5, 2024
Merged

Update Dockerfile #21

merged 1 commit into from
May 5, 2024

Conversation

praseodym
Copy link
Member

@praseodym praseodym commented May 5, 2024 •
edited
Loading

  • Use cargo build to ensure lockfile is used
  • Install libssl3 without development files
  • Use entrypoint to avoid shell invocation

@praseodym praseodym requested a review from JoepdeJong May 5, 2024 09:04
@praseodym praseodym marked this pull request as ready for review May 5, 2024 09:04
@praseodym
Update Dockerfile
58762e7 
- Use `cargo build` to ensure lockfile is used
- Install `libssl3` without development files
- Use entrypoint to avoid shell invocation
@JoepdeJong
Copy link
Contributor

Does this affect the devcontainer?

@praseodym
Copy link
Member Author

Does this affect the devcontainer?

Don't think so, the devcontainer uses its own image.

@JoepdeJong JoepdeJong merged commit e46b3cc into main May 5, 2024
1 check passed
@JoepdeJong JoepdeJong deleted the docker branch May 5, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoepdeJong JoepdeJong JoepdeJong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@praseodym @JoepdeJong