forked from argoproject/Argo
-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync develop branch with master #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync Develop
…omy-list, which were breaking the build somehow: https://readthedocs.org/projects/largo/builds/4590201/
Rename this one box
…yline first, I guess
In Largo_Byline::avatar(), swap the test around to do the coauthors byline first
Make the $author_id property of Largo_Byline and extending classes public
Make sure that both Guest Author and WP User avatar types have the same classes
Scroll fix for largo twitter widget: make the entire interior scrollable
Post Comment Errors
## What's Broken $hero_class and $classes variables are being printed, rather than their values printed in the template. ## More Info See 0a47feb#diff-216f6d639b07286f59ca7d39193160f8R124
…on so it can be added to child themes
I'm not able to duplicate the bug described in #1381, but this looks like a fix: exclude the current post from the posts that get returned in any query in the Largo_Related class, which is what feeds the Largo Related Posts widget. Please watch tests on this one.
Probable fix for #1381
… story and list of stories from the same series" layout sidebar stories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.