Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THEMES-760: Identity Blocks | Login links block #1713

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

vgalatro
Copy link
Contributor

@vgalatro vgalatro commented Jul 28, 2023

Description

This PR adds in the Login links block that accompanies the sign up and log in forms. It also corrects some styling issues with the single column layout related to the display of these blocks.

Jira Ticket

Acceptance Criteria

Login links block is converted to v2.

Test Steps

  1. Checkout this branch git checkout THEMES-760
  2. Run fusion repo with linked blocks npx fusion start -f -l @wpmedia/identity-block,@wpmedia/single-column-layout-block
  3. Create a page using the single column layout.
  4. Add the Identity Log In - Arc Block and the Identity Login Links - Arc Block to the "body" section of the page.
  5. In the Identity Login Links - Arc Block make sure "Show Forgot Password link" and "Show Sign up link" are checked. You can customized the URLs for each as well.
  6. Make sure the login links appear below the form as seen on the designs (https://www.figma.com/file/vWVGgZfZVBdSX7ACo3kmjr/Enhanced-Styling-Design-System?type=design&node-id=12874-178005&mode=design&t=JptOC1IZ0G9wCmAD-4).
  7. Now replace Identity Log In - Arc Block with Identity Sign Up - Arc Block.
  8. In the Identity Login Links - Arc Block make sure "Show Login link" is checked. You can customized the URL as well.
  9. Make sure the login link appear below the form as seen on the designs (https://www.figma.com/file/vWVGgZfZVBdSX7ACo3kmjr/Enhanced-Styling-Design-System?type=design&node-id=8411-119293&mode=design&t=BeXCdtxm1ekWDLRJ-4).

Author Checklist

  • Confirmed all the test steps a reviewer will follow above are working.
  • Confirmed there are no linter errors. Please run npm run lint to check for errors. Often, npm run lint:fix will fix those errors and warnings.
  • Ran this code locally and checked that there are not any unintended side effects. For example, that a CSS selector is scoped only to a particular block.
  • Confirmed this PR has reasonable code coverage. You can run npm run test:coverage to see your progress.
    • Confirmed this PR has unit test files
    • Ran npm run test, made sure all tests are passing
    • If the amount of work to write unit tests for this change are excessive,
      please explain why (so that we can fix it whenever it gets refactored).
  • Confirmed relevant documentation has been updated/added.

Reviewer Checklist

The reviewer of the PR should copy-paste this template into the review comments on review.

  • Linting code actions have passed.
  • Ran the code locally based on the test instructions.
    • I don’t think this is needed to be tested locally. For example, a padding style change (storybook?) or a logic change (write a test).
  • I am a member of the engine theme team so that I can approve and merge this. If you're not on the team, you won't have access to approve and merge this pr.
  • Looked to see that the new or changed code has code coverage, specifically. We want the global code coverage to keep on going up with targeted testing.

@vgalatro vgalatro added the ready for review The PR author has completed the PR template and is ready for a review label Jul 28, 2023
@vgalatro vgalatro requested a review from a team as a code owner July 28, 2023 17:11
@annasherman annasherman self-assigned this Aug 1, 2023
@vgalatro vgalatro merged commit f86ef43 into arc-themes-release-version-2.0.3 Aug 8, 2023
6 checks passed
@vgalatro vgalatro deleted the THEMES-760 branch August 8, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review The PR author has completed the PR template and is ready for a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants