Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THEMES-1276 Updated color-primary to blue-6 #1718

Merged
merged 3 commits into from
Aug 15, 2023

Conversation

malavikakoppula
Copy link
Contributor

@malavikakoppula malavikakoppula commented Aug 9, 2023

Description

Update color-primary to blue-6

Jira Ticket

Acceptance Criteria

color-primary is blue-6

Test Steps

  1. Checkout this branch git checkout THEMES-1276
  2. Run fusion repo with linked blocks npx fusion start -f -l @wpmedia/extra-large-promo-block
  3. test for icon-label background-color to be blue-6

Effect Of Changes

Before

Screenshot 2023-08-09 at 3 29 31 PM

After

Screenshot 2023-08-09 at 3 21 58 PM

Dependencies or Side Effects

Author Checklist

The author of the PR should fill out the following sections to ensure this PR is ready for review.

  • Confirmed all the test steps a reviewer will follow above are working.
  • Confirmed there are no linter errors. Please run npm run lint to check for errors. Often, npm run lint:fix will fix those errors and warnings.
  • Ran this code locally and checked that there are not any unintended side effects. For example, that a CSS selector is scoped only to a particular block.
  • Confirmed this PR has reasonable code coverage. You can run npm run test:coverage to see your progress.
    • Confirmed this PR has unit test files
    • Ran npm run test, made sure all tests are passing
    • If the amount of work to write unit tests for this change are excessive,
      please explain why (so that we can fix it whenever it gets refactored).
  • Confirmed relevant documentation has been updated/added.

Reviewer Checklist

The reviewer of the PR should copy-paste this template into the review comments on review.

  • Linting code actions have passed.
  • Ran the code locally based on the test instructions.
    • I don’t think this is needed to be tested locally. For example, a padding style change (storybook?) or a logic change (write a test).
  • I am a member of the engine theme team so that I can approve and merge this. If you're not on the team, you won't have access to approve and merge this pr.
  • Looked to see that the new or changed code has code coverage, specifically. We want the global code coverage to keep on going up with targeted testing.

@malavikakoppula malavikakoppula marked this pull request as ready for review August 14, 2023 14:50
@malavikakoppula malavikakoppula requested a review from a team as a code owner August 14, 2023 14:50
@malavikakoppula malavikakoppula added the ready for review The PR author has completed the PR template and is ready for a review label Aug 14, 2023
@vgalatro vgalatro self-assigned this Aug 14, 2023
@vgalatro vgalatro added the review in progress A review is underway. Even if an approval has been submitted, wait for all reviews to be completed. label Aug 14, 2023
Copy link
Contributor

@vgalatro vgalatro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think we may need a follow up ticket for button hover styles. The default styling for the primary button component variant, for example, has a dark gray hover color and is correctly using the new color-primary when not hovered.

@vgalatro vgalatro added ready for design qa Development complete and approved, ready for design to review and removed ready for review The PR author has completed the PR template and is ready for a review review in progress A review is underway. Even if an approval has been submitted, wait for all reviews to be completed. labels Aug 14, 2023
@vgalatro vgalatro removed their assignment Aug 14, 2023
@malavikakoppula
Copy link
Contributor Author

LGTM! I think we may need a follow up ticket for button hover styles. The default styling for the primary button component variant, for example, has a dark gray hover color and is correctly using the new color-primary when not hovered.

@vgalatro Thanks for the catch. Just created new PR in components repo: WPMedia/arc-themes-components#203

@malavikakoppula malavikakoppula merged commit 54944e6 into arc-themes-release-version-2.0.3 Aug 15, 2023
6 checks passed
@malavikakoppula malavikakoppula deleted the THEMES-1276 branch August 15, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for design qa Development complete and approved, ready for design to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants