Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated cardlist block to respect offsetOverride #2152

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

blakeganderson
Copy link
Contributor

@blakeganderson blakeganderson commented May 30, 2024

Be sure to run npm test, npm run lint, and write detailed test steps before requesting reviewers

Description

Jira Ticket: THEMES-1951

Previously, only the headline would update when you added an offset Override. The image, date and attribution all stayed the same (from the first story). This update makes it so that all data and the image is accurate based on the offset Override. This doc has more info on the proper configuration of card-list-blocks: https://docs.arcxp.com/alc/en/themes-using-promo-and-list-blocks?sys_kb_id=0ef1355483a202d0107cb2b8beaad3e0&id=kb_article_view&sysparm_rank=1&sysparm_tsqueryId=2890afec83e282d0107cb2b8beaad3b4#mcetoc_1heiur8ipb

Before:
image
After:
image

Test Steps

Add detailed test steps a reviewer must complete to test this PR

  1. Checkout this branch git checkout THEMES-1951
  2. Run fusion repo with linked blocks npx fusion start -f -l @wpmedia/card-list-block
  3. Add 3 card list blocks to a page (I added to a triple chain to make them easier to compare)
  4. In each block, select a collection as the content source, and use the configuration below with overrides of 0,1, and 2:
image 5. Make sure that the content rendered in each block corresponds to the correct story in the collection.

@blakeganderson blakeganderson requested a review from a team as a code owner May 30, 2024 21:57
@blakeganderson blakeganderson added the ready for review The PR author has completed the PR template and is ready for a review label Jun 6, 2024
@vgalatro vgalatro added review in progress A review is underway. Even if an approval has been submitted, wait for all reviews to be completed. and removed ready for review The PR author has completed the PR template and is ready for a review labels Jun 6, 2024
Copy link
Contributor

@vgalatro vgalatro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgalatro vgalatro added ready to merge It's time! Merge this PR. Woo! and removed review in progress A review is underway. Even if an approval has been submitted, wait for all reviews to be completed. labels Jun 6, 2024
@blakeganderson blakeganderson merged commit 18d582f into arc-themes-release-version-2.5.0 Jun 6, 2024
8 checks passed
@blakeganderson blakeganderson deleted the THEMES-1951 branch June 6, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge It's time! Merge this PR. Woo!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants