updated cardlist block to respect offsetOverride #2152
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to run
npm test
,npm run lint
, and write detailed test steps before requesting reviewersDescription
Jira Ticket: THEMES-1951
Previously, only the headline would update when you added an offset Override. The image, date and attribution all stayed the same (from the first story). This update makes it so that all data and the image is accurate based on the offset Override. This doc has more info on the proper configuration of card-list-blocks: https://docs.arcxp.com/alc/en/themes-using-promo-and-list-blocks?sys_kb_id=0ef1355483a202d0107cb2b8beaad3e0&id=kb_article_view&sysparm_rank=1&sysparm_tsqueryId=2890afec83e282d0107cb2b8beaad3b4#mcetoc_1heiur8ipb
Before:
After:
Test Steps
Add detailed test steps a reviewer must complete to test this PR
git checkout THEMES-1951
npx fusion start -f -l @wpmedia/card-list-block