Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add editable headline and description for medium-promo-block #2217

Merged
merged 5 commits into from
Sep 12, 2024
Merged

Add editable headline and description for medium-promo-block #2217

merged 5 commits into from
Sep 12, 2024

Conversation

Gripholder
Copy link
Collaborator

@Gripholder Gripholder commented Sep 12, 2024 •
edited by jira bot
Loading

Be sure to run npm test, npm run lint, and write detailed test steps before requesting reviewers

Description

Jira Ticket: THEMES-2013

Add editable headline and description for medium-promo-block
Screenshot 2024-09-12 at 9 29 34 AM

Test Steps

Add detailed test steps a reviewer must complete to test this PR

  1. Checkout this branch git checkout THEMES-2013
  2. Run fusion repo with linked blocks npx fusion start -f -l @medium-promo-block
  3. Verify that the medium promo has an editable headline and description: http://localhost/pagebuilder/editor/curate?p=pRHgb9ScMtKyMDwOt&v=vnxm88raOnKyMDwOt

@Gripholder Gripholder requested a review from a team as a code owner September 12, 2024 19:03
nschubach
nschubach previously approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@nschubach nschubach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Gripholder Gripholder merged commit 9e56a21 into arc-themes-release-version-2.5.1 Sep 12, 2024
8 checks passed
@Gripholder Gripholder deleted the THEMES-2013 branch September 12, 2024 20:25
Gripholder added a commit that referenced this pull request Sep 17, 2024
@Gripholder
Revert "Add editable headline and description for medium-promo-block (#…
bee6966 
…2217)"

This reverts commit 9e56a21.
@Gripholder Gripholder mentioned this pull request Sep 17, 2024
Merged
blakeganderson pushed a commit that referenced this pull request Sep 17, 2024
@Gripholder
Revert "Add editable headline and description for medium-promo-block" (…
647bfc7 
…#2220)

Revert "Add editable headline and description for medium-promo-block (#2217)"

This reverts commit 9e56a21.
@blakeganderson blakeganderson restored the THEMES-2013 branch October 11, 2024 15:14
@blakeganderson blakeganderson mentioned this pull request Oct 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschubach nschubach nschubach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gripholder @nschubach