-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASUB-8899 Match password sign up #2268
Merged
LauraPinilla
merged 6 commits into
arc-themes-release-version-2.5.2
from
ASUB-8899_SignUp-match-password
Nov 8, 2024
Merged
ASUB-8899 Match password sign up #2268
LauraPinilla
merged 6 commits into
arc-themes-release-version-2.5.2
from
ASUB-8899_SignUp-match-password
Nov 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardcho1231
previously approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
blakeganderson
previously approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LauraPinilla
dismissed stale reviews from blakeganderson and edwardcho1231
via
November 7, 2024 19:00
351be1b
blakeganderson
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LauraPinilla
merged commit Nov 8, 2024
735d2ed
into
arc-themes-release-version-2.5.2
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to run
npm test
,npm run lint
, and write detailed test steps before requesting reviewersDescription
Jira Ticket: THEMES-
https://arcpublishing.atlassian.net/browse/ASUB-8899
Information about what you changed for this PR. Include any dependencies, companion PRs, relevant screenshots, or config changes.
if you fall into the web page and enter
QA?123a
as password in both fields, you will see the "password must match" error.List of special characters was increased. The BE is using the logic below for special characters
Test Steps
Add detailed test steps a reviewer must complete to test this PR
git checkout {branch name}
npx fusion start -f -l {blocks to link}