Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASUB-8899 Match password sign up #2268

Merged

Conversation

LauraPinilla
Copy link
Contributor

@LauraPinilla LauraPinilla commented Oct 31, 2024

Be sure to run npm test, npm run lint, and write detailed test steps before requesting reviewers

Description

Jira Ticket: THEMES-

https://arcpublishing.atlassian.net/browse/ASUB-8899

Information about what you changed for this PR. Include any dependencies, companion PRs, relevant screenshots, or config changes.

if you fall into the web page and enter QA?123a as password in both fields, you will see the "password must match" error.

List of special characters was increased. The BE is using the logic below for special characters
image

Test Steps

Add detailed test steps a reviewer must complete to test this PR

  1. Checkout this branch git checkout {branch name}
  2. Run fusion repo with linked blocks npx fusion start -f -l {blocks to link}
  3. {Next ....}

@LauraPinilla LauraPinilla requested a review from a team as a code owner October 31, 2024 23:23
edwardcho1231
edwardcho1231 previously approved these changes Nov 1, 2024
Copy link
Contributor

@edwardcho1231 edwardcho1231 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

blakeganderson
blakeganderson previously approved these changes Nov 1, 2024
Copy link
Contributor

@blakeganderson blakeganderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@blakeganderson blakeganderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LauraPinilla LauraPinilla merged commit 735d2ed into arc-themes-release-version-2.5.2 Nov 8, 2024
8 checks passed
@LauraPinilla LauraPinilla deleted the ASUB-8899_SignUp-match-password branch November 8, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants