Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-added null value check #708

Merged
merged 2 commits into from
May 24, 2024
Merged

Re-added null value check #708

merged 2 commits into from
May 24, 2024

Conversation

vgalatro
Copy link
Contributor

Added back in a check for null values in the signImagesInANSObject utility. Also added a test for the observed bug.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 24, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3e90284

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

blakeganderson
blakeganderson approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@blakeganderson blakeganderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vgalatro vgalatro merged commit f4e2d50 into develop May 24, 2024
3 checks passed
@vgalatro vgalatro deleted the fix-sign-images-null-handling branch May 24, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakeganderson blakeganderson blakeganderson approved these changes

Assignees
No one assigned
Labels
Ready to Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vgalatro @blakeganderson