New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More vue updates #193

Draft

RoelN wants to merge 3 commits into master from more-vue-updates

Contributor

RoelN commented Oct 9, 2024

Use proper ID to scrollTo
Consistently name modal events (as mentioned here by @danieldiekmeier)
Avoid recursive updates (possible suspect: $filters)

RoelN added 3 commits

October 9, 2024 08:34


          Use proper ID to scroll to font report

b9376a1

How could this have worked before?!


          Consistently rename modal events

be35a03


          Prevent recursive updates in font summary

19788e6

Contributor Author

RoelN commented Oct 9, 2024

Have to stop now, but two more things to investigate:

The select in FeatureControls
Something in OpenTypeFeatures

These are making Vue hang. Probably I'm triggering these recursive updates because I'm a doofus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet