Divyanshu | Stage | Convert Tax module into material #14016

nisha-walkover · 2024-10-03T06:57:49Z

https://app.clickup.com/t/86cwmfhbm

dvCodeWorld · 2024-11-12T07:42:36Z

apps/web-giddh/src/app/gst/filing/filing.component.html

@@ -39,7 +39,7 @@
                    class="nav-band"
                    [hidden]="(gstr1OverviewDataInProgress$ | async) || (gstr2OverviewDataInProgress$ | async)"
                >
-                    <tabset #staticTabs id="c-tab" class="custom-tabs gstr-tabs-head">
+                    <!-- <tabset #staticTabs id="c-tab" class="custom-tabs gstr-tabs-head">


Remove comment

dvCodeWorld · 2024-11-12T07:49:26Z

apps/web-giddh/src/app/gst/filing/filing.component.html

+                    <mat-tab [label]="localeData?.filing?.tabs?.overview">
+                        <div
+                            class="transactions-overview mr-b4"
+                            *ngIf="selectedTab === localeData?.filing?.tabs?.overview || !selectedTabId"


check this logic and implement tab logic

dvCodeWorld · 2024-11-12T07:49:39Z

apps/web-giddh/src/app/gst/filing/filing.component.html

+                        </div>
+                    </mat-tab>
+                    <mat-tab [label]="localeData?.filing?.tabs?.reconcilation" *ngIf="selectedGst === GstReport.Gstr2 || selectedGst === GstReport.Gstr1">
+                        <!-- <div *ngIf="selectedTab === localeData?.filing?.tabs?.reconcilation || selectedTabId === 1"> -->


remove comment

dvCodeWorld · 2024-11-12T07:49:54Z

apps/web-giddh/src/app/gst/filing/filing.component.html

+                        <div class="transactions-overview">
+                            <div class="gstr-transactions-summary mr-t4 mr-b4 text-center">
+                                <div class="successful-file-detail" hidden>
+                                    <img src="assets/images/file-successful.svg" />


alt attribute

dvCodeWorld · 2024-11-12T07:50:19Z

apps/web-giddh/src/app/gst/filing/filing.component.html

+                                    <img src="assets/images/file-successful.svg" />
+                                    <h3>{{ localeData?.filing?.gst_filed }}</h3>
+                                    <p>{{ localeData?.filing?.return_file_note }}</p>
+                                    <button


In material

dvCodeWorld · 2024-11-12T09:55:35Z

...rc/app/reports/components/reverse-charge-report-component/reverse-charge-report.component.ts

@@ -16,6 +16,7 @@ import { BsModalRef, BsModalService } from 'ngx-bootstrap/modal';
 import { GeneralService } from '../../../services/general.service';
 import { BreakpointObserver } from '@angular/cdk/layout';
 import { Router } from '@angular/router';
+import { UntypedFormControl } from "@angular/forms";


dvCodeWorld · 2024-11-12T09:55:58Z

...rc/app/reports/components/reverse-charge-report-component/reverse-charge-report.component.ts

@@ -89,6 +90,22 @@ export class ReverseChargeReport implements OnInit, OnDestroy {
    public isMobileScreen: boolean = true;
    /** True if today selected */
    public todaySelected: boolean = false;
+    displayedColumns: string[] = [


dvCodeWorld · 2024-11-12T09:56:57Z

apps/web-giddh/src/app/settings/taxes/confirmation/confirmation.model.component.html

+    </mat-dialog-content>
+
+
+    <!-- <div class="modal-header">


check commented code

dvCodeWorld · 2024-11-12T09:58:20Z

apps/web-giddh/src/app/settings/taxes/setting.taxes.component.ts

-        this.confirmationMessage = message;
-        this.confirmationFor = 'delete';
-        this.taxConfirmationModel?.show();
+    public deleteTax(taxToDelete): void {


dvCodeWorld · 2024-11-12T10:00:07Z

apps/web-giddh/src/assets/css/global/color.scss

@@ -0,0 +1,4 @@
+/*-------------- Background Color ----------------*/
+// .bg-white {


…/Giddh-New-Angular4-App into 86cwf7nuh-tax-stage

coderabbitai · 2024-12-20T10:27:01Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

nisha-walkover added 7 commits September 24, 2024 14:25

tax module in material

594e478

tax module in material

e70b1dd

add vehicle dialog

2476fa9

manage tax reverse charge tab in material

bc84628

gst setting in material

df59d85

add datepicker

ab54d51

add mat-paginator remove console

cbb6dac

nisha-walkover requested a review from ravinderwalkover as a code owner October 3, 2024 06:57

add page paginator module in gst

1d18959

dvCodeWorld requested changes Nov 12, 2024

View reviewed changes

conflict resolved

ae3b612

dvCodeWorld changed the title ~~Nisha | Stage | Convert Tax module into material~~ Divyanshu | Stage | Convert Tax module into material Nov 14, 2024

dvCodeWorld added 11 commits November 14, 2024 19:15

Working on gst ,odule in material

4441547

Working on GST module in material

facee9c

working on gst summary and transaction

f513a27

compelete gst module in material

f1b5897

Merge branch 'beta-stage' of https://github.com/Walkover-Web-Solution…

c8c25cf

…/Giddh-New-Angular4-App into 86cwf7nuh-tax-stage

Ewaybill code complete | Version 2

fc9bbba

Conflict resolved

061edfb

Pr changes 2

d8d6933

Pr changes 3

a3d1685

Take pull and conflict resolved

c8323e7

take pull and conflict resolved

527eefb

dvCodeWorld added 4 commits December 21, 2024 19:30

working on version 3

61a8d92

Working on tax setting module

b9c41fc

Take pull and conflict resolved

49023f8

Use common confirmation dialog for delete tax

c67d4bd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Divyanshu | Stage | Convert Tax module into material #14016

Divyanshu | Stage | Convert Tax module into material #14016

nisha-walkover commented Oct 3, 2024

dvCodeWorld Nov 12, 2024

dvCodeWorld Nov 12, 2024

dvCodeWorld Nov 12, 2024

dvCodeWorld Nov 12, 2024

dvCodeWorld Nov 12, 2024

dvCodeWorld Nov 12, 2024

dvCodeWorld Nov 12, 2024

dvCodeWorld Nov 12, 2024

dvCodeWorld Nov 12, 2024

dvCodeWorld Nov 12, 2024

coderabbitai bot commented Dec 20, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

		@@ -0,0 +1,4 @@
		/-------------- Background Color ----------------/
		// .bg-white {

Divyanshu | Stage | Convert Tax module into material #14016

Are you sure you want to change the base?

Divyanshu | Stage | Convert Tax module into material #14016

Conversation

nisha-walkover commented Oct 3, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coderabbitai bot commented Dec 20, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

CodeRabbit Configuration File (`.coderabbit.yaml`)