Shivani | Stage | Prod - Change subscription expiry message in case of auto renewal #14329

shivanivani02 · 2024-12-12T14:02:26Z

https://app.clickup.com/t/86cx9rybp

coderabbitai · 2024-12-12T14:02:34Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

dvCodeWorld · 2024-12-20T12:03:35Z

apps/web-giddh/src/app/shared/header/header.component.ts

-            ?.replace("[PLAN_NAME]", this.subscribedPlan?.planDetails?.name ?? '')
-            ?.replace("[EXPIRY_DATE]", this.subscribedPlan?.expiry ?? '');
+        let text = "";
+        if (['MONTHLY', 'DAILY'].includes(this.subscribedPlan?.duration)) {


Suggested change

if (['MONTHLY', 'DAILY'].includes(this.subscribedPlan?.duration)) {

if (['MONTHLY', 'DAILY'].includes(this.subscribedPlan?.duration) && !subscribedPlan?.isSubTrialOrCancelled) {

dvCodeWorld · 2024-12-20T12:06:12Z

apps/web-giddh/src/assets/locale/header/en.json

@@ -3,6 +3,7 @@
    "click_here": "Click here",
    "subscription_end_note": "Your [PLAN_DURATION] [PLAN_DURATION_UNIT] plan - [PLAN_NAME] will end on [EXPIRY_DATE]. Apply to upgrade your subscription.",
    "subscription_ended_note": "Your [PLAN_DURATION] [PLAN_DURATION_UNIT] plan - [PLAN_NAME] ended on [EXPIRY_DATE]. Apply to upgrade your subscription.",
+    "subscription_expire_renewal_message": "The payment has been initiated. The subscription will be renewed upon successful payment processing.",


Suggested change

"subscription_expire_renewal_message": "The payment has been initiated. The subscription will be renewed upon successful payment processing.",

"subscription_expire_renewal_message": "The payment has been initiated. Your subscription will be renewed upon successful payment processing.",

dvCodeWorld · 2024-12-20T13:43:46Z

apps/web-giddh/src/app/shared/header/header.component.ts

@@ -256,6 +256,8 @@ export class HeaderComponent implements OnInit, AfterViewInit, OnDestroy, AfterV
    public planVersion: number;
    /** Hold broadcast event */
    public broadcast: any;
+    /** Hold the message of subscription plane get expire and remains day wise*/


Suggested change

/** Hold the message of subscription plane get expire and remains day wise*/

/** Holds true if plan is either trail or cancelled */

dvCodeWorld · 2024-12-20T13:44:19Z

apps/web-giddh/src/assets/locale/header/mr.json

@@ -3,6 +3,7 @@
 	"click_here": "इथे क्लिक करा",
 	"subscription_end_note": "तुमची [PLAN_DURATION] [PLAN_DURATION_UNIT] योजना - [PLAN_NAME] [EXPIRY_DATE] रोजी समाप्त होईल. तुमची सदस्यता अपग्रेड करण्यासाठी अर्ज करा",
 	"subscription_ended_note": "तुमची [PLAN_DURATION] [PLAN_DURATION_UNIT] योजना - [PLAN_NAME] [EXPIRY_DATE] रोजी संपली. तुमची सदस्यता अपग्रेड करण्यासाठी अर्ज करा",
+    "subscription_expire_renewal_message": "पेमेंट सुरू करण्यात आले आहे. यशस्वी पेमेंट प्रक्रियेनंतर तुमचे सदस्यत्व नूतनीकरण केले जाईल.",


Suggested change

"subscription_expire_renewal_message": "पेमेंट सुरू करण्यात आले आहे. यशस्वी पेमेंट प्रक्रियेनंतर तुमचे सदस्यत्व नूतनीकरण केले जाईल.",

"subscription_expire_renewal_message": "पेमेंट सुरू करण्यात आले आहे. यशस्वी पेमेंट प्रक्रियेनंतर तुमचे सदस्यत्व नूतनीकरण केले जाईल",

shivanivani02 and others added 3 commits December 12, 2024 18:42

change subscription expiry message

d1c64ab

Change subscription expiry-2nd

a7c73b9

Change duration key as requirement

b2dbf43

shivanivani02 requested a review from ravinderwalkover as a code owner December 12, 2024 14:02

Pr changes

f6c84e1

dvCodeWorld requested changes Dec 20, 2024

View reviewed changes

added key of subscription plane expire

c253659

dvCodeWorld requested changes Dec 20, 2024

View reviewed changes

shivanivani02 added 2 commits December 20, 2024 19:18

PR chnages

a30e7ab

remaining PR changes

126ddf1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Shivani | Stage | Prod - Change subscription expiry message in case of auto renewal #14329

Shivani | Stage | Prod - Change subscription expiry message in case of auto renewal #14329

shivanivani02 commented Dec 12, 2024

coderabbitai bot commented Dec 12, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

dvCodeWorld Dec 20, 2024

dvCodeWorld Dec 20, 2024

dvCodeWorld Dec 20, 2024

dvCodeWorld Dec 20, 2024

	if (['MONTHLY', 'DAILY'].includes(this.subscribedPlan?.duration)) {
	if (['MONTHLY', 'DAILY'].includes(this.subscribedPlan?.duration) && !subscribedPlan?.isSubTrialOrCancelled) {

	"subscription_expire_renewal_message": "The payment has been initiated. The subscription will be renewed upon successful payment processing.",
	"subscription_expire_renewal_message": "The payment has been initiated. Your subscription will be renewed upon successful payment processing.",

	/** Hold the message of subscription plane get expire and remains day wise*/
	/** Holds true if plan is either trail or cancelled */

Shivani | Stage | Prod - Change subscription expiry message in case of auto renewal #14329

Are you sure you want to change the base?

Shivani | Stage | Prod - Change subscription expiry message in case of auto renewal #14329

Conversation

shivanivani02 commented Dec 12, 2024

coderabbitai bot commented Dec 12, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

dvCodeWorld Dec 20, 2024

Choose a reason for hiding this comment

dvCodeWorld Dec 20, 2024

Choose a reason for hiding this comment

dvCodeWorld Dec 20, 2024

Choose a reason for hiding this comment

dvCodeWorld Dec 20, 2024

Choose a reason for hiding this comment

coderabbitai bot commented Dec 12, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)