fix: don't block startup on subscribe #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekbrother
reviewed
Feb 12, 2024
| .observe(&ctx, subscriber_topics_count as u64, &[]); | ||
| metrics.subscribe_latency.record(&ctx, elapsed, &[]); | ||
| } else { | ||
| info!("Renew operation already running"); |
There was a problem hiding this comment.
Do we really need to print this log?
There was a problem hiding this comment.
Nice to have for later debugging if necessary
geekbrother
reviewed
Feb 12, 2024
| .try_into() | ||
| .expect("No error getting ms of elapsed time"); | ||
| info!("resubscribe took {elapsed}ms"); | ||
| const REQUEST_CONCURRENCY: usize = 25; |
There was a problem hiding this comment.
Is it ok to decrease this almost to 10 times?
There was a problem hiding this comment.
The variable was re-purposed. It was actually already set to 25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the blocking subscribe from startup. Because we've switched to webhooks, we do not need to associate the subscription with the websocket, and the relay will remember the subscription for 30 days. We still need to renew, so that async job is still there. This will be improved with #325
Improving startup time allows the service to start, which apparently it isn't starting anymore due to the length of time it takes to subscribe being longer than the healthcheck allowance: https://walletconnect.slack.com/archives/C058RS0MH38/p1707770358630189?thread_ts=1707766935.771459&cid=C058RS0MH38
How Has This Been Tested?
Not tested
Due Diligence