Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apns): proper handling of the invalid provider token response #347

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

geekbrother
Copy link
Contributor

Description

This PR adds a proper handling of the APNS InvalidProviderToken error response. This error type reflects that the APNS certificate should be reissued, switching between business and personal accounts is causing this response.

How Has This Been Tested?

Not tested.

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@geekbrother geekbrother self-assigned this Nov 13, 2024
@arein arein added the accepted The issue has been accepted into the project label Nov 13, 2024
@geekbrother geekbrother changed the title feat(apns): proper handling of the invalid provider token response fix(apns): proper handling of the invalid provider token response Nov 13, 2024
Copy link
Member

@chris13524 chris13524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geekbrother geekbrother merged commit 3d241bc into main Nov 15, 2024
10 checks passed
@geekbrother geekbrother deleted the fix/handle_invalid_provider_token branch November 15, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted The issue has been accepted into the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants