Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change universal-provider to use merge from es-toolkit instead of lodash #5629

Open
wants to merge 3 commits into
base: v2.0
Choose a base branch
from

Conversation

elee1766
Copy link

@elee1766 elee1766 commented Feb 2, 2025

Description

changes the merge function used to be from lodash to es-toolkit https://github.com/toss/es-toolkit/tree/main

it should be compatible, and results in a much smaller bundle size for consumers.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

i cant run the tests because i dont know how to configure a relay

Fixes/Resolves (Optional)

#5628

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)

i dont really know the process here. please let me know if there is something i can read / what i should do to help this go through

@ganchoradkov ganchoradkov self-requested a review February 3, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant