Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade @types/redux-logger to 3.0.9 to fix dev mode #356

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Downgrade @types/redux-logger to 3.0.9 to fix dev mode #356

merged 1 commit into from
Nov 14, 2024

Conversation

ZoogieZork
Copy link
Contributor

Description

Downgrades @types/redux-logger to 3.0.9.

Motivation and Context

Fixes the UI in dev mode. Newer versions are incompatible.

How Has This Been Tested?

Tested locally via npm start.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist

  • My code follows conforms to the coding standards.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ZoogieZork
Downgrade @types/redux-logger to 3.0.9.
9df7c0b 
Newer versions are incompatible with Redux Toolkit v1.
@ZoogieZork ZoogieZork changed the title Downgrade @types/redux-logger to 3.0.9 Downgrade @types/redux-logger to 3.0.9 to fix dev mode Nov 13, 2024
@ZoogieZork ZoogieZork marked this pull request as ready for review November 13, 2024 23:35
@ZoogieZork ZoogieZork requested a review from a team as a code owner November 13, 2024 23:35
g-marconet
g-marconet approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@g-marconet g-marconet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZoogieZork ZoogieZork merged commit 222c01b into main Nov 14, 2024
5 checks passed
@ZoogieZork ZoogieZork deleted the zoogiezork/types-redux-logger-3.0.9 branch November 14, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-marconet g-marconet g-marconet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZoogieZork @g-marconet