Plugin runner: Support plugins that use Docker #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches how the engine container is started in a full deployment (see docker-compose.aws.yml). This enables support for plugins which scan local container images.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Plugin Runner tool now supports plugins that need to use Docker (e.g. trivy).
This is accomplished the same way we do it in the AWS deployment, by mounting the
docker.sockin the engine as a volume that gets inherited by the plugin containers -- seedocker-compose.aws.yml.Motivation and Context
Plugins that use Docker would previously just hang on execution.
How Has This Been Tested?
Tested running the Trivy plugin locally.
Types of changes
Checklist