Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify cmake version checks #2605

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ximex
Copy link
Contributor

@ximex ximex commented Feb 26, 2022

@past-due
Copy link
Member

VERSION_GREATER_EQUAL is not available in CMake < v3.7, which we (currently) must support for some platforms.

@ximex
Copy link
Contributor Author

ximex commented Feb 26, 2022

Here cmake 3.10+ is mentioned
https://github.com/Warzone2100/warzone2100#windows-using-msvc
and here it's already used. this is why i thought this version requirement is no problem
https://github.com/Warzone2100/warzone2100/blob/master/configure_mac.cmake#L241

@ximex
Copy link
Contributor Author

ximex commented Feb 26, 2022

i see we still build for ubuntu 16.04 that has an older cmake version. do we really need ubuntu 16.04 builds? support ended April 2021

@past-due
Copy link
Member

Yes, for Windows and macOS we recommend newer versions.

For other platforms (ex. Linux / BSDs) we currently only require CMake 3.5+, which is why we set the main requirement as such here:

https://github.com/Warzone2100/warzone2100/blob/master/CMakeLists.txt#L1

@ximex ximex force-pushed the simplify-cmake-version-checks branch from 6104483 to 767ca7b Compare September 16, 2023 19:43
@KJeff01 KJeff01 added the PR: Needs Review Check if this PR is still relevant or needs minor tweaks to be ready to merge label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Needs Review Check if this PR is still relevant or needs minor tweaks to be ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants