Resolve #3011 -- Fixing the suggested save names #3398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KJeff01
changed the title
|
Looks and tests good. Only issue I see is some spelling mistakes in commit titles. |
|
Thank you for the quick response! Should I rebase the commit and change the commits messages (this will probably rerun all the tests)? Or when merging you will rewrite the commit message? |
|
You can reword the commits. |
|
I reworded them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #3011.
The saving mechanism works as follows:
This fixes the problem where the suggested names have already existed sometimes.
I added a commit at the start that resolves many compilation errors of std::min/max not found and a linking issue with to_json function when trying to compile on Windows using CMake on VS2019. Please let me know if I should remove this commit.