-
-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve classic tree models (+ shadows) & "floating features" issues #3679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
past-due
commented
Mar 9, 2024
•
edited
Loading
edited
- Instead of a few 2d planes, use actual tree models with 3D volume
- Enable shadow-casting for trees
- Improve issue with features sometimes floating significantly above terrain
past-due
force-pushed
the
2024_02_tree_shadows_1
branch
from
March 17, 2024 18:55
70ece4f
to
e195dfc
Compare
past-due
changed the title
renderFeature: Enable shadow-casting for trees
Improve classic tree models (+ shadows) & improve "floating features" issues
Mar 17, 2024
past-due
changed the title
Improve classic tree models (+ shadows) & improve "floating features" issues
Improve classic tree models (+ shadows) & "floating features" issues
Mar 17, 2024
past-due
force-pushed
the
2024_02_tree_shadows_1
branch
from
March 17, 2024 22:31
e195dfc
to
298f6c7
Compare
ManManson
reviewed
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Little comment in updateFeatureOrientation()
, otherwise good.
By the way, brand-new trees look great! Kudos to @MaNGusT- |
Instead of a few 2d planes, actual models with 3D volume Co-Authored-By: MaNGusT- <[email protected]>
Co-Authored-By: MaNGusT- <[email protected]>
The larger tree features were set to a width+breadth of 2x2 tiles, but they really only take up 1 tile. Adjust this to 1x1 so trees can be placed next to each other if desired.
past-due
force-pushed
the
2024_02_tree_shadows_1
branch
from
March 27, 2024 00:54
298f6c7
to
c706d8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.