Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve classic tree models (+ shadows) & "floating features" issues #3679

Merged
merged 6 commits into from
Mar 27, 2024

Conversation

past-due
Copy link
Member

@past-due past-due commented Mar 9, 2024

  • Instead of a few 2d planes, use actual tree models with 3D volume
  • Enable shadow-casting for trees
  • Improve issue with features sometimes floating significantly above terrain

@past-due past-due force-pushed the 2024_02_tree_shadows_1 branch from 70ece4f to e195dfc Compare March 17, 2024 18:55
@past-due past-due changed the title renderFeature: Enable shadow-casting for trees Improve classic tree models (+ shadows) & improve "floating features" issues Mar 17, 2024
@past-due past-due marked this pull request as ready for review March 17, 2024 20:33
@past-due past-due changed the title Improve classic tree models (+ shadows) & improve "floating features" issues Improve classic tree models (+ shadows) & "floating features" issues Mar 17, 2024
@past-due past-due added this to the 4.5.0-beta1 milestone Mar 17, 2024
@past-due past-due force-pushed the 2024_02_tree_shadows_1 branch from e195dfc to 298f6c7 Compare March 17, 2024 22:31
@ManManson ManManson self-requested a review March 18, 2024 08:57
Copy link
Member

@ManManson ManManson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little comment in updateFeatureOrientation(), otherwise good.

src/feature.cpp Outdated Show resolved Hide resolved
@ManManson
Copy link
Member

By the way, brand-new trees look great! Kudos to @MaNGusT-

past-due and others added 6 commits March 26, 2024 20:52
Instead of a few 2d planes, actual models with 3D volume

Co-Authored-By: MaNGusT- <[email protected]>
The larger tree features were set to a width+breadth of 2x2 tiles, but they really only take up 1 tile. Adjust this to 1x1 so trees can be placed next to each other if desired.
@past-due past-due force-pushed the 2024_02_tree_shadows_1 branch from 298f6c7 to c706d8c Compare March 27, 2024 00:54
@past-due past-due merged commit d38d6f5 into Warzone2100:master Mar 27, 2024
33 checks passed
@past-due past-due deleted the 2024_02_tree_shadows_1 branch March 27, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants