Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch features to use PagedEntityContainer<FEATURE> as backing storage #3707

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Switch features to use PagedEntityContainer<FEATURE> as backing storage #3707

merged 1 commit into from
Mar 26, 2024

Conversation

ManManson
Copy link
Member

  1. Split the feature storage into pages containing 128 features
  2. Disable slot reuse to guard against memory-related issues when some object pointers won't get updated properly, e.g. when transitioning between the base and offworld missions.

@ManManson ManManson added this to the 4.5.0-beta1 milestone Mar 25, 2024
@ManManson ManManson requested a review from past-due March 25, 2024 13:37
@ManManson
Switch FEATURE to use PagedEntityContainer<FEATURE> as backing st…
146b84a 
…orage

1. Split the feature storage into pages containing 128 features
2. Disable slot reuse to guard against memory-related issues
   when some object pointers won't get updated properly,
   e.g. when transitioning between the base and offworld missions.

Signed-off-by: Pavel Solodovnikov <[email protected]>
@ManManson ManManson force-pushed the features_optimized_storage branch from 4bb6236 to 146b84a Compare March 25, 2024 15:26
@past-due past-due merged commit 62cea65 into Warzone2100:master Mar 26, 2024
38 checks passed
@ManManson ManManson deleted the features_optimized_storage branch April 23, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@past-due past-due past-due approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
4.5.0-beta1
Development

Successfully merging this pull request may close these issues.
2 participants
@ManManson @past-due