Sound fixes #3716
Merged
Sound fixes #3716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
KJeff01
commented
Mar 29, 2024
•
KJeff01
commented
- Fixed generator power hum appearing while loading saves and disappearing after coming back onto the home map (put it in effects). I turned it into a one-shot sound so it doesn't need a special function to stop it, and this also prevents an ancient issue where deconstructing the power-generator still had this sound looping as it was being demolished.
- Prevent Oil derrick pump sound from persisting onto offworld maps where they would be on the home map.
- Fixed audio pause state never being set, add a few more (hopefully not problematic).
- Cleanup.
- Rename some confusing function names.
Prevents this sound from appearing mid-saveload if the camera is positioned near a generator. Also fixes the hum sound disappearing after coming back from an away mission. Made this a "one-shot" sound so it does not need an explicit `audio_StopObjTrack()` to stop it.
Do not need to explicitly stop this sound as the audio system can detect if samples are tied to dead objects.
With this patch `g_bAudioPaused` checks will finally do something if enabled. Fixed any issues that would have come up from this check working, such as avoiding the pause check in `audio_PlayTrack()` which plays in-game menu sounds for example.
So we don't need to check `g_bAudioPaused` directly in various places.
Renamed `audio_CheckSameQueueTracksPlaying()` as it was not very clear on what it actually does.
`audio_CheckSame3DTracksPlaying()` was not clear on what it actually does.
|
Just going to disable the pause stuff for now. I have something huge coming up after this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.