Convert audio .cfg files to JSON #3722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Massive cleanup of lexer/parser code for audio sound effect file loading. This is done by passing information straight to `audio_setTrackVals()` from a JSON file.
|
Is there a reason to underscore-prefix some attributes? I understand that some of these are not actually used in the code and serve only as a means to add some structure to the file. But I think it would be nicer if we had no underscore prefixes at all. |
|
I think I've come across JSON linters/beautifiers out there that may alphabetically sort key-value pairs. There isn't a standard for denoting comments in JSON as it's not technically supported, but using underscores is one of them that I've seen others suggest and seems the most legible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do a little code deletion.
audio_setTrackVals()from a JSON file.To keep it modder friendly I put "comments" in the JSON files and copied the ones that were already there to begin with from the old .cfg files.
I didn't touch the cmake file for lib/gamelib which may need a tweak now that I deleted these. That directory is also almost empty now. Other than that everything loads and plays just fine from my tests.