netplay, netsocket: pass references to sockets wherever possible #3729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavel Solodovnikov <[email protected]>
ManManson
force-pushed
the
netplay_minor_refactoring_3
branch
from
3a0ff61 to
646d6e2
Compare
ManManson
changed the title
unique_ptr:s
|
Removed |
past-due
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shouldn't change any existing behavior. It's mostly enhancements directed towards having safer APIs, i.e.:
Pass references instead of pointers to sockets wherever possible. This is more self-documenting than having a pointer signature with non-null annotation, and is harder to misuse.
Signed-off-by: Pavel Solodovnikov [email protected]