Fix tiles under skyscrapers not changing to rubble #3731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Squelch a multiplication warning with the for loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the worst bugs this game has ever seen. Oh, how terribly it ruined the aesthetic of Urban tilesets not seeing rubble tiles appear automatically below a destroyed skyscraper. After much torment had this weighed on my mind, I decided to find out how to fix it yet again. By luck or pure genius I eventually found the means to get this working again. And yes, these tiles will persist with the new rubble texture through saveloads.
Fixes #2871.
(Extracted out a way to dirty all tiles which seems like it could be a useful function to have).