Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for MP rules script #3828

Merged
merged 4 commits into from
May 31, 2024
Merged

Fixes for MP rules script #3828

merged 4 commits into from
May 31, 2024

Conversation

KJeff01
Copy link
Member

@KJeff01 KJeff01 commented May 31, 2024

  • Reticule buttons were assuming removObject() had immediate effect (as before wzapi: change removeObject API function to defer object removal #3736). Resulting in an incorrect reticule button state where many buttons were available at the start of a No Bases match.
  • Delays the match settings message by a tick making it show up. I assume something with how console messages are displayed isn't the same as it was when this was first introduced.
  • Fixes some comments.
  • Move CyborgSpade into the automatically researched truck component research as we can definitely enable cyborg components through research. Thus removing a weird unnecessary hack in the scripts.

KJeff01 added 4 commits May 31, 2024 10:33
To account for `removeObject()` change.
Stops console messages for match settings at the start of the match from disappearing very quickly.
There is no special reason why this can't be enabled by research.
@KJeff01 KJeff01 added this to the 4.5.0-beta1 milestone May 31, 2024
@KJeff01 KJeff01 merged commit ce99946 into Warzone2100:master May 31, 2024
37 checks passed
@KJeff01 KJeff01 deleted the mprulesfix branch May 31, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant