Prevent underflow in getMissionTime() calculation #3918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`mission.time` undergoes signed to unsigned int promotion, and when `mission.time` is -1 either from initialization or from a setMissionTime(-1) to disable the timer, it would result in huge values being returned. This resulted in the scripted power auto-gain bonus giving the player maximum power in this case.
This previously relied on the underflow issue and not correcting it would mean no timer would appear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mission.timeundergoes signed to unsigned int promotion, and whenmission.timeis -1 either from initialization or from a setMissionTime(-1) to disable the timer, it would result in huge values being returned.This resulted in the scripted power auto-gain bonus giving the player maximum power in this case.