Fix: loadSaveResearch should not restore "pending" bits #4024
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: Nevermind, see comment below.
These are only used for the UI in modes that use the netqueues (i.e. skirmish, etc), and only set while waiting for the netqueue to process a research action.However, savegames do not contain the netqueues, so if a save occurs between the time that the user takes a UI action (which sets the state to pending) and when the tick is processed, it could lead to research topics disappearing on saveload (since pending state is restored, but not the changes queued for the unprocessed game tick).
Testing: