Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug: can't build if the droid is centered in the tile #4141

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

Monsterovich
Copy link
Contributor

@Monsterovich Monsterovich commented Nov 22, 2024

Fixes #4137

In case anyone is curious, the truck will be pushed to the top. I think, in this rare case, the direction doesn't matter.

@aco4
Copy link
Contributor

aco4 commented Nov 22, 2024

Seems like a very hacky solution

@Monsterovich
Copy link
Contributor Author

Monsterovich commented Nov 22, 2024

Seems like a very hacky solution

@aco4 Why? If you build a factory in the center with another droid, actionRemoveDroidsFromBuildPos will push the droid to the top. This behavior is already there, only it didn't work if the droid builds on itself.

demo.mp4

@aco4
Copy link
Contributor

aco4 commented Nov 22, 2024

Ah, I misunderstood the implementation. Looks like a good solution, great work!

@KJeff01 KJeff01 added this to the 4.6.0 milestone Nov 23, 2024
@KJeff01 KJeff01 modified the milestones: 4.6.0, 4.6.0-beta1 Dec 8, 2024
@KJeff01 KJeff01 merged commit 0506f44 into Warzone2100:master Dec 8, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Perfectly centered truck can't build factory on top of itself
3 participants