Pass on instruciton syntax #137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does some tweaks to the instruction syntax.
I had to change the syntax of loadops from
sz sxtosz _ sx, in order to make sure that the show hint actually applies. I adapted convert.ml accordingly, but unfortunately, the change still breaks the interpreter, which encounters someLet (n, sx) = loadopwith a tuple on the lhs. I could not figure out where this let is coming from — it does not appear in the AL shown with --print-al, nor could I find a place in the backend code that introduces it. So I'm a bit puzzled.@f52985, any help is appreciated.