Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landing/Home Page #167

Merged
merged 16 commits into from
Jan 20, 2021
Merged

Landing/Home Page #167

merged 16 commits into from
Jan 20, 2021

Conversation

versx
Copy link
Collaborator

@versx versx commented Sep 12, 2020

Adds an optional home/landing page instead of just looping the login screen.
Credits to Anonymous and Alvadi for the two pages

@Mygod
Copy link
Contributor

Mygod commented Sep 12, 2020

wtf is this home2

@versx
Copy link
Collaborator Author

versx commented Sep 12, 2020

wtf is this home2

Secondary landing page I just need to get the updated one from Alvadi that has the login button. Need to make both .example.mustache files for people to choose from (or create their own).

@Mygod
Copy link
Contributor

Mygod commented Sep 12, 2020

That cheap photoshop tho lol. Anyway I wouldn't recommend impersonating discord.

@versx
Copy link
Collaborator Author

versx commented Sep 12, 2020

That cheap photoshop tho lol. Anyway I wouldn't recommend impersonating discord.

Yeah you're right

@clburlison
Copy link
Contributor

I'm going to assume this is still a work in progress? Overall I really like the idea. Looks much better on mobile than desktop IMO. I can see users wanting to customize this screen quite a bit which leads to resurrecting #64 with the popup template support, or adding more config options for home.mustache:

  • the background picture
  • slash/title/main picture
  • Title text
  • body text

If you want help on moving this forward please let us know what direction you want to take.

@versx
Copy link
Collaborator Author

versx commented Sep 12, 2020

I'm going to assume this is still a work in progress? Overall I really like the idea. Looks much better on mobile than desktop IMO. I can see users wanting to customize this screen quite a bit which leads to resurrecting #64 with the popup template support, or adding more config options for home.mustache:

  • the background picture
  • slash/title/main picture
  • Title text
  • body text

If you want help on moving this forward please let us know what direction you want to take.

Kind of, just whipped it together real quick didn't put much customization into it. I also see people wanting to custom it with more options. Making it template-able would be ideal I think for allowing full customization. I'll try and get to the templates again this weekend.

@versx versx added the enhancement New feature or request label Sep 28, 2020
@versx
Copy link
Collaborator Author

versx commented Jan 1, 2021

Please test and provide feedback.

Tell users why they can't access the site

Signed-off-by: Clayton Burlison <[email protected]>
@clburlison clburlison mentioned this pull request Jan 2, 2021
@clburlison
Copy link
Contributor

Everything is working for me in this PR. I made a few minor tweaks over in 309 to make it a bit more mobile friendly plus added a minor enhancement in 😅 We don't have the customization options added but at this point I think it might be a better idea to get this merged in and let more people use it, then add in the customizations afterwards.

versx and others added 3 commits January 2, 2021 07:43
- Added things to config/mustache
- CSS
- Consolidated homepage items into one config category for simplicity
@TurtIeSocks TurtIeSocks mentioned this pull request Jan 4, 2021
TurtIeSocks and others added 2 commits January 3, 2021 21:17
Copy link
Contributor

@clburlison clburlison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running this in prod over here. While it isn't perfect it's a nice improvement over the current behavior on master.

@versx versx merged commit ce8cdd6 into master Jan 20, 2021
@versx versx deleted the landing-page branch January 20, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants